Revert "ci: skip workflows for PRs tagged with skip ci#4301
Merged
Conversation
…p-ci` (apache#4291)" This reverts commit db0dbcf.
andygrove
changed the title
[skip ci] or labeled skip-ci"skip-ci"
andygrove
changed the title
skip-ci"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[skip ci]or labeledskip-ci#4291 because theif:conditions on jobs cause GitHub to treat skipped required status checks as passing, allowing PRs to merge without tests running.Follow-up
We need a different approach to allow skipping CI during iteration while still requiring tests before merge. Options include:
github.event.pull_request.draft == false) combined with a gate job pattern🤖 Generated with Claude Code