chore: native_datafusion use try_pushdown_filters#4299
Merged
Conversation
Contributor
Author
|
Marking as draft while I review some behavior based on discussion in today's DataFusion weekly call. I don't want this merged yet. |
Contributor
Author
|
I updated the comments based on my research. This is okay to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Discussion in apache/datafusion#22026 highlighted that Comet indiscriminately pushes filters into the scan without checking if they can be pushed down. This doesn't lead to incorrect behavior because we always have a FilterExec node above the scan anyway, so if any filters can't actually be pushed down then we get evaluation above. DataFusion wants to enforce a contract that
try_pushdown_filtersis called first, so let's adhere to that. Eventually we might introduce an optimization to elide the FilterExec if everything is successfully pushed down, but that's out of scope for this PR.What changes are included in this PR?
Call
try_pushdown_filtersinstead of building the CNF of filters in Comet and usingwith_predicate.How are these changes tested?
Existing tests.