compare the file scheme case-insensitively in isValid - #433
Open
sahvx655-wq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chasing why an all upper case
FILE:URL validated differently from its lower case twin led back toisValid.isValidSchemematches the scheme case-blind (it lower-cases before the allow-list check, and RFC 3986 3.1 makes schemes case-insensitive), but the file handling just below it tests"file".equals(scheme)twice, so aFILE:orFile:scheme takes neither branch.FILE:///etc/hostswhile acceptingfile:///etc/hosts.ALLOW_LOCAL_URLSthe authorityFILE://C:/some.fileis accepted although the byte-identicalfile://C:/some.fileis rejected as it should be (testValidator276already pins the lower case form as never valid).Computed the file-scheme test once with
equalsIgnoreCaseand reused it in both places. Left unfixed the second case is a validation bypass: an allow-list keyed on the scheme lets a crafted upper case authority slip past the guard the lower case form is stopped by. AddedtestFileSchemeCaseInsensitive, which fails on master and passes with the change.mvn; that'smvnon the command line by itself.