gha(python): fix W391 blank line at end of file - #6897
Merged
Merged
Conversation
flake8 --select=W291,W292,W293,W391 . ./test/integration/smoke/test_register_userdata.py:766:1: W391 blank line at end of file ./test/integration/component/test_network_vpc_custom_dns.py:732:1: W391 blank line at end of file
DaanHoogland
approved these changes
Nov 13, 2022
Contributor
|
@jbampton are you running these tests locally? they are not run in any of the travis jobs. |
Member
Author
|
Yes I run https://github.com/apache/cloudstack/actions/runs/3454836056/jobs/5766433087 |
Member
Author
|
In future we could add There is another pull request where I was adding the first check with refs #6273 |
Contributor
|
daring to go against principle on this one, only empty lines on end of files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flake8 --select=W291,W292,W293,W391 .
./test/integration/smoke/test_register_userdata.py:766:1: W391 blank line at end of file
./test/integration/component/test_network_vpc_custom_dns.py:732:1: W391 blank line at end of file
Description
This PR fixes the
flake8testTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?