Allow for arbitrary disk offering details to be saved/displayed

[mlsorensen]

Similar to service offering details, allow details to be provided and
displayed. Can be used for classification of offerings, etc.

Signed-off-by: Marcus Sorensen mls@apple.com

Description

This PR relaxes the disk offering details to match the way the service offering details work. With Service offering details, any arbitrary values provided can be saved and displayed, which can be used as metadata to tag, classify, or organize offerings by higher level consumers. With disk offerings, any detail that isn't recognized is ignored, so this PR relaxes that and persists arbitrary details as well.

Note that with both disk offerings and service offerings, there are a few 'special' detail keys that are marked display=false when they are persisted, and this functionality remains intact.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested locally, properly displays arbitrary details and hides the special details that are marked display=false when queried as non-admin user.

(localhost) 🐱 > create diskoffering name=test displaytext=test disksize=1 details[0].foo=bar details[0].iopsLimit=200
{
  "diskoffering": {
    "created": "2022-06-15T16:29:17+0000",
    "details": {
      "foo": "bar",
      "iopsLimit": "200"
    },
    "disksize": 1,
    "displayoffering": true,
    "displaytext": "test",
    "hasannotations": false,
    "id": "a9787073-4704-4bdc-a03f-69e514b79926",
    "iscustomized": false,
    "name": "test",
    "provisioningtype": "thin",
    "storagetype": "shared"
  }
}
(localhost) 🐱 > set profile localhost-user
Loaded in-built API cache. Failed to read API cache, please run 'sync'.
Loaded server profile: localhost-user
Url:         http://localhost:8080/client/api
Username:    user
Domain:      /
API Key:
Total APIs:  590

(localhost-user) 🐱 > list diskofferings id=a9787073-4704-4bdc-a03f-69e514b79926
{
  "count": 1,
  "diskoffering": [
    {
      "created": "2022-06-15T16:29:17+0000",
      "details": {
        "foo": "bar"
      },
      "disksize": 1,
      "displayoffering": true,
      "displaytext": "test",
      "hasannotations": false,
      "id": "a9787073-4704-4bdc-a03f-69e514b79926",
      "iscustomized": false,
      "name": "test",
      "provisioningtype": "thin",
      "storagetype": "shared"
    }
  ]
}

[sureshanaparti]

code LGTM

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3595

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4339)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36579 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6474-t4339-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[acs-robot]

Found UI changes, kicking a new UI QA build
@blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✖️
(SL-JID-1)

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6474 (SL-JID-1797)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[GabrielBrascher]

Code LGTM.