Add check for update only name and/or description of disk offering - #6410
Merged
DaanHoogland merged 2 commits intoJun 27, 2022
Merged
Conversation
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Contributor
|
@BryanMLima Similar issue is with updateServiceOffering for host and storage tags, is it possible to add check for that as well? |
|
Found UI changes, kicking a new UI QA build |
Contributor
Author
|
@shwstppr I added the verification for service offerings as well. I tested on my lab, and worked as intended. |
|
Kudos, SonarCloud Quality Gate passed!
|
shwstppr
approved these changes
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While trying to update a disk offering through the UI, the tag fields are always sent, even when they are not changed. This causes a bug when active volumes are using a disk offering in storage pools with tags. As ACS would interpret this as an update on the tags as well. This PR aims to fix this problem, only sending the tags if they are different from the current tags, allowing the user to update the name and/or description of disk offerings, as it is already allowed through CloudMonkey.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
On a local lab, I tried updating the disk offering with the following use cases:
All of the tests worked as expected, the UI only sent the the fields that were changed.
Then, while trying to update the name and/or description fields, and changing the tags as well, the API was sending the tags parameters, as expected.