[KVM improve logs in migrate VM process - #6331
Merged
DaanHoogland merged 7 commits intoJun 28, 2022
Merged
Conversation
PR Analysishttps://sonarcloud.io/summary/new_code?id=apachecloudstack&pullRequest=6331 PR Coverage Report
|
Member
|
@blueorangutan package |
|
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3326 |
DaanHoogland
reviewed
May 3, 2022
Member
|
Can you merge latest main branch to your PR branch @SadiJr ? |
|
SonarCloud Quality Gate failed. |
…add-logs-to-migrate-vm-process
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
SonarCloud Quality Gate failed. |
GabrielBrascher
approved these changes
Jun 27, 2022
GabrielBrascher
left a comment
GabrielBrascher
left a comment
Member
There was a problem hiding this comment.
Interesting log enhancements, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve the logs in migrate VM process, when using KVM as hypervisor, to facilitate future troubleshooting. We faced a situation that the lack of logs in this process made the troubleshooting pretty hard. Therefore, we are proposing to improve it.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
It's tested in a local lab: