Removed unused labels - #6326
Conversation
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
looks like a good cleanup @JoaoJandre , thanks. Be prepared that it is going to results in conflicts pretty often. Can you please share the scripts somehow? It'll be easier to maintain in the future.
Thanks @DaanHoogland , the scripts were made to be used once, so they aren't ''pretty'', but I can certainly share them: https://pastebin.com/2m7KA5sB |
I understand, @JoaoJandre . I just fear that this will have iterations due to conflicts and want to make sure we keep evidence for prosterity in case of mishaps. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Kudos, SonarCloud Quality Gate passed! |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
looks good, clicked around and couldn´t find any missing labels so far. |
|
travis has a failure, but that cannot be related |








Description
This PR builds on PR #6281, it aims to clean the UI label files by removing all labels that are no longer being used. There are more than three thousand labels on en.json; therefore, I used some scripts to help me with that. The following steps were used to determine which labels where unused:
grep -r -l -i '<key>', saving in another file all the results found.Ps: the
el_GR.jsonfile wasn't properly formatted (it had a space between every key and its ':'), so when it was loaded/dumped it was reformatted into right format. That's why it shows that every line in it was changed.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
This was tested in a local lab, by looking through all the UI and searching any missing labels that could have been mistakenly deleted.