Skip to content

Enable flake8 rule W292 No newline at end of file - #6274

Merged
yadvr merged 1 commit into
apache:mainfrom
jbampton:enable-flake8-W292
Jun 30, 2022
Merged

Enable flake8 rule W292 No newline at end of file#6274
yadvr merged 1 commit into
apache:mainfrom
jbampton:enable-flake8-W292

Conversation

@jbampton

Copy link
Copy Markdown
Member

https://www.flake8rules.com/rules/W292.html

Description

This PR adds checking for flake8 rule W292. A blank line has been added where needed.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@nvazquez nvazquez added this to the 4.17.1.0 milestone Apr 20, 2022

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@yadvr
yadvr merged commit 7ba43e4 into apache:main Jun 30, 2022
@yadvr yadvr modified the milestones: 4.17.1.0, 4.18.0.0 Jun 30, 2022
@yadvr

yadvr commented Jun 30, 2022

Copy link
Copy Markdown
Member

Looks like lint checks are passing, merged based on that.

@jbampton
jbampton deleted the enable-flake8-W292 branch June 30, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants