Skip to content

Revert "parallel nic adding" - #5665

Merged
nvazquez merged 1 commit into
mainfrom
revert-5541-synchronous-nic-adding
Nov 4, 2021
Merged

Revert "parallel nic adding"#5665
nvazquez merged 1 commit into
mainfrom
revert-5541-synchronous-nic-adding

Conversation

@nvazquez

@nvazquez nvazquez commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

Reverts #5541

PR is reverted as the issues is not fixed completely, another issue raised: #5651. The fix for it introduces regressions on Travis runs: #5658

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nvazquez

nvazquez commented Nov 4, 2021

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the constraint needs to be removed, but this will work. note that #5499 is re-opened with this (cc @div8cn)

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1674

@nvazquez

nvazquez commented Nov 4, 2021

Copy link
Copy Markdown
Contributor Author

Travis passed, merging based on approvals and packaging, no smoke tests needed

@nvazquez
nvazquez merged commit 261fe32 into main Nov 4, 2021
@nvazquez
nvazquez deleted the revert-5541-synchronous-nic-adding branch November 10, 2021 01:59

@hsdgd hsdgd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hayesy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants