Skip to content

UI - Deploy VM with params from the template, iso, network pages - #5653

Merged
sureshanaparti merged 4 commits into
apache:4.16from
EWERK-DIGITAL:feature/deploy-vm-with-params
Jan 13, 2022
Merged

UI - Deploy VM with params from the template, iso, network pages#5653
sureshanaparti merged 4 commits into
apache:4.16from
EWERK-DIGITAL:feature/deploy-vm-with-params

Conversation

@utchoang

@utchoang utchoang commented Nov 2, 2021

Copy link
Copy Markdown

Description

This PR fixes #5639

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang

utchoang commented Nov 2, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan

blueorangutan commented Nov 2, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Nov 2, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-802)

@yadvr

yadvr commented Nov 2, 2021

Copy link
Copy Markdown
Member

I think the specific parameter should be passed to the url and be picked up by the form.

@utchoang

utchoang commented Nov 3, 2021

Copy link
Copy Markdown
Author

@rhtyd Will now pass the template id, network id on the URL, and will auto-select it on the form.

@yadvr
yadvr changed the base branch from main to 4.16 November 15, 2021 10:15
@yadvr yadvr added this to the 4.16.1.0 milestone Nov 15, 2021
@yadvr

yadvr commented Nov 18, 2021

Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan

blueorangutan commented Nov 18, 2021

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@yadvr
yadvr requested review from Pearl1594 and shwstppr and removed request for shwstppr November 18, 2021 08:23
@blueorangutan

blueorangutan commented Nov 18, 2021

Copy link
Copy Markdown

UI build: ✖️
(SL-JID-835)

@sureshanaparti

sureshanaparti commented Dec 16, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

yadvr
yadvr reviewed Dec 30, 2021
View reviewed changes

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs testing

@shwstppr

shwstppr commented Dec 30, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

1 similar comment
@sureshanaparti

sureshanaparti commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

blueorangutan commented Jan 3, 2022

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jan 3, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-967)

@yadvr

yadvr commented Jan 8, 2022

Copy link
Copy Markdown
Member

@blueorangutan ui

1 similar comment
@sureshanaparti

sureshanaparti commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

blueorangutan commented Jan 10, 2022

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jan 10, 2022

Copy link
Copy Markdown

UI build: ✖️
(SL-JID-992)

@sureshanaparti

sureshanaparti commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

blueorangutan commented Jan 10, 2022

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jan 10, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-996)

@sureshanaparti

sureshanaparti commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

Verified deploy VM from template and network. LGTM.

weizhouapache
weizhouapache approved these changes Jan 13, 2022
View reviewed changes

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok. thanks for fixing.

@sureshanaparti
sureshanaparti merged commit 001f421 into apache:4.16 Jan 13, 2022
@sureshanaparti sureshanaparti mentioned this pull request Jan 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr left review comments
@sureshanaparti sureshanaparti sureshanaparti approved these changes
@weizhouapache weizhouapache weizhouapache approved these changes
@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594
@shwstppr shwstppr Awaiting requested review from shwstppr
@davidjumani davidjumani Awaiting requested review from davidjumani

Assignees

No one assigned

Labels

component:UI

Projects

No open projects
Apache CloudStack 4.16.1
Status: Done

Milestone

4.16.1.0

Development

Successfully merging this pull request may close these issues.

[UI] feature request: deploy vm with param from previous page

6 participants

@utchoang @blueorangutan @yadvr @sureshanaparti @shwstppr @weizhouapache