Skip to content

IPv6: fix deploy vm issue in ipv6-only networks without VR - #5648

Merged
yadvr merged 2 commits into
apache:4.16from
shapeblue:4.16-fix-ipv6-only-shared
Nov 18, 2021
Merged

IPv6: fix deploy vm issue in ipv6-only networks without VR#5648
yadvr merged 2 commits into
apache:4.16from
shapeblue:4.16-fix-ipv6-only-shared

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes #5640 partially.

Ipv6-only shared network with offering "Quickcloud with no services" works with this PR.
Ipv6-only shared network with other offerings, which require VR, still does not work, as VR cannot start.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache weizhouapache changed the title IPv6: fix deploy vm issue in ipv6-only networks IPv6: fix deploy vm issue in ipv6-only networks without VR Nov 1, 2021
@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1651

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test matrix

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2503)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30272 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5648-t2503-xenserver-71.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2504)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31188 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5648-t2504-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2505)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34106 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5648-t2505-vmware-65u2.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Comment thread server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java Outdated

@GabrielBrascher GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @weizhouapache.
+1 on Daan's suggestion on extracting those lines into a method.

Code LGTM.

@yadvr yadvr added this to the 4.16.1.0 milestone Nov 9, 2021
@weizhouapache
weizhouapache changed the base branch from main to 4.16 November 11, 2021 08:46
@yadvr
yadvr merged commit dd458fe into apache:4.16 Nov 18, 2021
@weizhouapache
weizhouapache deleted the 4.16-fix-ipv6-only-shared branch December 9, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

NPE while deploy vm on a IPv6-only shared network

7 participants