Skip to content

UI - Add a setting to config.json that allows users to set theme - #5584

Merged
sureshanaparti merged 1 commit into
apache:4.16from
EWERK-DIGITAL:feature/ui-dark-mode-config
Jan 17, 2022
Merged

UI - Add a setting to config.json that allows users to set theme#5584
sureshanaparti merged 1 commit into
apache:4.16from
EWERK-DIGITAL:feature/ui-dark-mode-config

Conversation

@utchoang

Copy link
Copy Markdown

Description

Add a setting to config.json that allows users to set theme

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang

Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5584 (SL-JID-763)

@utchoang
utchoang changed the base branch from main to 4.16 November 16, 2021 09:05
@yadvr yadvr added this to the 4.16.1.0 milestone Nov 25, 2021
@sureshanaparti

Copy link
Copy Markdown
Contributor

Hi @shwstppr can you test this please.

@Pearl1594 Pearl1594 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shows the Page styling drawer on setting the config to true.

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sureshanaparti
sureshanaparti merged commit a42ed1f into apache:4.16 Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants