api,server: add params for updatehypervisorcapabilities API by shwstppr · Pull Request #5473 · apache/cloudstack

shwstppr · 2021-09-20T09:26:14Z

Description

Allows updating following capabilities for a hypervisor, version:

Max DATA volumes limit
Storage motion supported
Max hosts per cluster
VM snapshot enabled

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Using cmk:

(local) 🦌 > list hypervisorcapabilities id=7e83442b-19ed-11ec-93bc-645d8651f45a
{
  "count": 1,
  "hypervisorCapabilities": [
    {
      "hypervisor": "Simulator",
      "hypervisorversion": "default",
      "id": "7e83442b-19ed-11ec-93bc-645d8651f45a",
      "maxdatavolumeslimit": 6,
      "maxguestslimit": 50,
      "securitygroupenabled": true,
      "storagemotionenabled": true,
      "vmsnapshotenabled": false
    }
  ]
}
(local) 🦅 > update hypervisorcapabilities id=7e83442b-19ed-11ec-93bc-645d8651f45a maxdatavolumeslimit=32 maxguestslimit=64 securitygroupenabled=false storagemotionenabled=false vmsnapshotenabled=true maxhostspercluster=10
{
  "null": {
    "hypervisor": "Simulator",
    "hypervisorversion": "default",
    "id": "7e83442b-19ed-11ec-93bc-645d8651f45a",
    "maxdatavolumeslimit": 32,
    "maxguestslimit": 64,
    "maxhostspercluster": 10,
    "securitygroupenabled": false,
    "storagemotionenabled": false,
    "vmsnapshotenabled": true
  }
}

Allows updating following capabilities for a hypervisor, version: - Max DATA volumes limit - Storage motion supported - Max hosts per cluster - VM snapshot enabled Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-09-20T09:27:06Z

@blueorangutan package

blueorangutan · 2021-09-20T09:28:02Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-20T09:53:16Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1323

shwstppr · 2021-09-20T20:22:03Z

@blueorangutan test

blueorangutan · 2021-09-20T20:23:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-09-21T06:22:36Z

Trillian test result (tid-2137)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34595 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5473-t2137-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

sureshanaparti · 2022-01-13T12:43:53Z

@shwstppr Is this PR ready?

DaanHoogland

code looks generally good but I think in this case a simple integration test is in order.
a simple
update -> list -> verify -> update -> list -> verify
what do you think @shwstppr ?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2022-01-28T12:37:29Z

@DaanHoogland can you please have a look at the integration test added in the last commit. Should it be under components or smoke?

DaanHoogland

thanks for the test @shwstppr , some code suggestions and I see one issue in the test. Can you explain please?

Co-authored-by: dahn <daan.hoogland@gmail.com>

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland

clgtm

sureshanaparti · 2022-01-30T18:19:00Z

@blueorangutan package

blueorangutan · 2022-01-30T18:20:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-30T19:28:47Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2386

sureshanaparti · 2022-01-30T20:47:53Z

@blueorangutan test

blueorangutan · 2022-01-30T20:49:04Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-01-31T07:20:01Z

Trillian test result (tid-3063)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36361 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5473-t3063-kvm-centos7.zip
Smoke tests completed. 92 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_check_hypervisor_max_data_volume_limit	`Error`	89.58	test_hypervisor_capabilities.py
test_01_check_hypervisor_vm_snapshot	`Error`	43.71	test_hypervisor_capabilities.py

DaanHoogland · 2022-01-31T10:44:33Z

@shwstppr , these trillian failures seem related to the changes, can you have a look?

borisstoyanov

except the failing tests, rest LGTM

shwstppr · 2022-01-31T11:39:37Z

@DaanHoogland will check and update

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2022-02-02T06:39:35Z

@DaanHoogland as discussed, moved test to component and made fixes.

Detach volume was failing intermittently for multiple disks so added a stop VM statement
VM snapshots for a running VM is not supported on KVM so skipped that test for KVM.

Tested VMware and KVM. KVM logs below:

[root@pr5473-t3104-kvm-centos7-marvin marvin]# nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=./pr5473-t3104-kvm-centos7-advanced-cfg -s -a tags=advanced --hypervisor=KVM tests/component/test_hypervisor_capabilities.py 

==== Marvin Init Started ====

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

==== Log Folder Path: /marvin/MarvinLogs/Feb_02_2022_06_34_09_97PJFK All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====
=== TestName: test_01_check_hypervisor_max_data_volume_limit | Status : SUCCESS ===

=== Final results are now copied to: /marvin//MarvinLogs/test_hypervisor_capabilities_1R6CDP ===
[root@pr5473-t3104-kvm-centos7-marvin marvin]# cat /marvin//MarvinLogs/test_hypervisor_capabilities_1R6CDP/results.txt 
Test hypervisor maxdatavolumeslimit effect ... === TestName: test_01_check_hypervisor_max_data_volume_limit | Status : SUCCESS ===
ok
Test hypervisor vmsnapshotenabled effect ... SKIP: Skipping test: Reason -  VM Snapshot of running VM is not supported for KVM

----------------------------------------------------------------------
Ran 2 tests in 90.896s

OK (SKIP=1)

sureshanaparti · 2022-02-02T11:11:41Z

@blueorangutan package

blueorangutan · 2022-02-02T11:13:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-02T11:49:27Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2427

sureshanaparti · 2022-02-02T12:03:11Z

@blueorangutan test

blueorangutan · 2022-02-02T12:05:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-02T23:56:38Z

Trillian test result (tid-3124)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41197 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5473-t3124-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

api,server: add params for updatehypervisorcapabilities API

adc3208

Allows updating following capabilities for a hypervisor, version: - Max DATA volumes limit - Storage motion supported - Max hosts per cluster - VM snapshot enabled Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr closed this Sep 24, 2021

shwstppr reopened this Sep 24, 2021

yadvr changed the base branch from main to 4.16 November 15, 2021 10:09

yadvr added this to the 4.16.1.0 milestone Nov 25, 2021

sureshanaparti added the component:api label Jan 13, 2022

sureshanaparti assigned shwstppr Jan 13, 2022

shwstppr marked this pull request as ready for review January 17, 2022 06:08

DaanHoogland reviewed Jan 19, 2022

View reviewed changes

shwstppr added 2 commits January 28, 2022 15:08

Merge branch '4.16' into add-params-updatehypervisorcapabilities

cc42548

added test

9af03f5

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland reviewed Jan 28, 2022

View reviewed changes

shwstppr and others added 3 commits January 28, 2022 23:14

Update test/integration/smoke/test_hypervisor_capabilities.py

5ccde24

Co-authored-by: dahn <daan.hoogland@gmail.com>

Update test/integration/smoke/test_hypervisor_capabilities.py

04a1eb3

Co-authored-by: dahn <daan.hoogland@gmail.com>

changes

75142e2

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland reviewed Jan 29, 2022

View reviewed changes

Comment thread tools/marvin/marvin/lib/base.py

DaanHoogland approved these changes Jan 29, 2022

View reviewed changes

DaanHoogland assigned borisstoyanov and unassigned shwstppr Jan 29, 2022

borisstoyanov approved these changes Jan 31, 2022

View reviewed changes

borisstoyanov assigned shwstppr and unassigned borisstoyanov Jan 31, 2022

changes

9c3770f

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

sureshanaparti merged commit 62b806a into apache:4.16 Feb 3, 2022

Uh oh!

Conversation

shwstppr commented Sep 20, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

shwstppr commented Sep 20, 2021

Uh oh!

blueorangutan commented Sep 20, 2021

Uh oh!

blueorangutan commented Sep 20, 2021

Uh oh!

shwstppr commented Sep 20, 2021

Uh oh!

blueorangutan commented Sep 20, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

sureshanaparti commented Jan 13, 2022

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jan 28, 2022

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jan 30, 2022

Uh oh!

blueorangutan commented Jan 30, 2022

Uh oh!

blueorangutan commented Jan 30, 2022

Uh oh!

sureshanaparti commented Jan 30, 2022

Uh oh!

blueorangutan commented Jan 30, 2022

Uh oh!

blueorangutan commented Jan 31, 2022

Uh oh!

DaanHoogland commented Jan 31, 2022

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jan 31, 2022

Uh oh!

shwstppr commented Feb 2, 2022

Uh oh!

sureshanaparti commented Feb 2, 2022

Uh oh!

blueorangutan commented Feb 2, 2022

Uh oh!

blueorangutan commented Feb 2, 2022

Uh oh!

sureshanaparti commented Feb 2, 2022

Uh oh!

blueorangutan commented Feb 2, 2022

Uh oh!

blueorangutan commented Feb 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects