UI bug fix: Cannot deploy VM from ISO - #3995
Merged
andrijapanicsb merged 1 commit intoMar 30, 2020
Merged
Conversation
Member
Contributor
|
indeed... wow |
Contributor
|
@nvazquez can you also take a look - the issue is valid, and I would like to make sure the OVF stuff is not broken = then merge it. thx |
Contributor
|
The workaround is clicking on Next once this appears. I'll work on a fix |
Contributor
|
the fix is there @nvazquez ? |
Contributor
|
@blueorangutan package |
Contributor
|
(having some nasty JS overrides in my local lab, so need to build from packages - less effort) |
Contributor
|
@blueorangutan package |
|
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
nvazquez
approved these changes
Mar 30, 2020
Contributor
|
Yes @andrijapanicsb, thanks @ustcweizhou I haven't seen the fix sorry |
|
Packaging result: ✔centos7 ✔debian. JID-1107 |
andrijapanicsb
self-requested a review
March 30, 2020 18:26
andrijapanicsb
approved these changes
Mar 30, 2020
Contributor
|
2 x LGTM, manual testing. Regression testing not needed since a simple JS change/not applicable. Merging. |
Contributor
|
Thanks for noticing this @weizhouapache |
DaanHoogland
pushed a commit
that referenced
this pull request
Mar 30, 2020
* 4.13: UI bug fix: Cannot deploy VM from ISO (#3995)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While deploy a vm from ISO on UI, the instance wizard is not working in vm overview step.
this is regression issue of #3271
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?