With basic zone and VMware hypervisor, VR fails to start by harikrishna-patnala · Pull Request #3977 · apache/cloudstack

harikrishna-patnala · 2020-03-18T10:54:36Z

Description

With basic zone and VMware hypervisor, VR fails to start since eth1 is getting empty instead of a private IP.

Boot Args for VM[DomainRouter|r-4-VM]: template=domP name=r-4-VM eth0ip=10.3.0.89 eth0mask=255.255.224.0 gateway=10.3.31.254 domain=cs1cloud.internal cidrsize=19 dhcprange=10.3.0.1 eth1ip=0.0.0.0 eth1mask=0.0.0.0 mgmtcidr=10.2.0.0/16 localgw=10.2.254.254 sshonguest=true type=dhcpsrvr disable_rp_filter=true extra_pubnics=2 dns1=8.8.8.8

Though VMware does not support security groups, but in a basic zone with VMware and no isolation VMs should be able to deploy.

Fixes: #3031

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Created a VMware basic zone
Created a VM and Virtual router
VR is in running state with private IP assigned to it
VM deployment is also successful

harikrishna-patnala · 2020-03-19T04:41:44Z

@blueorangutan package

blueorangutan · 2020-03-19T04:42:54Z

@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-03-19T05:09:44Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1073

DaanHoogland · 2020-03-26T09:15:11Z

@blueorangutan package

blueorangutan · 2020-03-26T09:16:19Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-03-26T09:33:35Z

Packaging result: ✖centos7 ✖debian. JID-1091

…s getting empty instead of a private IP. Though VMware does not support security groups, but in a basic zone with VMware and no isolation VMs should be able to deploy. Root cause: In case of VMware and basic zone control nic is set to 0.0.0.0 assuming control network will be shared with guest network. But to have access to VMware instances management/private needs to be assigned to it. Solution: Assing a private ip even in case of basic zone VMware.

harikrishna-patnala · 2020-03-26T09:46:39Z

@blueorangutan package

blueorangutan · 2020-03-26T09:47:20Z

@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-03-26T10:04:22Z

Packaging result: ✔centos7 ✔debian. JID-1093

DaanHoogland

code lgtm, i'll setup up a vmware basic zone to verify

DaanHoogland · 2020-03-26T12:19:01Z

@blueorangutan test matrix

blueorangutan · 2020-03-26T12:19:20Z

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2020-03-26T20:53:48Z

Trillian test result (tid-1318)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29456 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3977-t1318-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	`Failure`	255.15	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	251.82	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	324.78	test_privategw_acl.py
test_01_scale_vm	`Failure`	20.48	test_scale_vm.py

blueorangutan · 2020-03-26T21:41:22Z

Trillian test result (tid-1320)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32311 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3977-t1320-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	`Failure`	250.54	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	277.40	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	381.53	test_privategw_acl.py

borisstoyanov · 2020-03-27T09:26:33Z

@blueorangutan test

blueorangutan · 2020-03-27T09:27:24Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2020-03-27T10:46:28Z

I started a vmware basic zone with this and started an instance 👍

andrijapanicsb · 2020-03-27T10:46:47Z

Once tests are fine, we are OK to merge.

blueorangutan · 2020-03-27T17:38:32Z

Trillian test result (tid-1328)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27933 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3977-t1328-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	`Failure`	183.92	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	170.73	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	257.16	test_privategw_acl.py

andrijapanicsb

LGTM

andrijapanicsb · 2020-03-27T18:45:36Z

2 x approvals, manual testing done OK, automated/regression tests all passing (failed ones are known test issues).

Merging based on ^^^

harikrishna-patnala force-pushed the VMwareBasicZoneFailsTogetPrivateIPonVR branch from 8450757 to 9b22133 Compare March 18, 2020 12:54

harikrishna-patnala changed the title ~~With basic zone and VMware hypervisor, VR fails to start~~ With basic zone and VMware hypervisor, VR fails to start. closes #3031 Mar 25, 2020

harikrishna-patnala changed the title ~~With basic zone and VMware hypervisor, VR fails to start. closes #3031~~ With basic zone and VMware hypervisor, VR fails to start Mar 25, 2020

harikrishna-patnala mentioned this pull request Mar 25, 2020

VMware basic zone VR fails to start and get private IP #3031

Closed

harikrishna-patnala force-pushed the VMwareBasicZoneFailsTogetPrivateIPonVR branch 3 times, most recently from 95a33c5 to 9811af1 Compare March 26, 2020 08:59

harikrishna-patnala marked this pull request as ready for review March 26, 2020 09:02

DaanHoogland added this to the 4.13.1.0 milestone Mar 26, 2020

harikrishna-patnala force-pushed the VMwareBasicZoneFailsTogetPrivateIPonVR branch from 9811af1 to 22e8fd3 Compare March 26, 2020 09:45

DaanHoogland approved these changes Mar 26, 2020

View reviewed changes

apache deleted a comment from blueorangutan Mar 27, 2020

apache deleted a comment from DaanHoogland Mar 27, 2020

andrijapanicsb self-requested a review March 27, 2020 18:44

andrijapanicsb approved these changes Mar 27, 2020

View reviewed changes

andrijapanicsb merged commit 78fda2d into apache:4.13 Mar 27, 2020

Uh oh!

Conversation

harikrishna-patnala commented Mar 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

harikrishna-patnala commented Mar 19, 2020

Uh oh!

blueorangutan commented Mar 19, 2020

Uh oh!

blueorangutan commented Mar 19, 2020

Uh oh!

DaanHoogland commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 26, 2020

Uh oh!

harikrishna-patnala commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 26, 2020

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 26, 2020

Uh oh!

blueorangutan commented Mar 26, 2020

Uh oh!

borisstoyanov commented Mar 27, 2020

Uh oh!

blueorangutan commented Mar 27, 2020

Uh oh!

DaanHoogland commented Mar 27, 2020

Uh oh!

andrijapanicsb commented Mar 27, 2020

Uh oh!

blueorangutan commented Mar 27, 2020

Uh oh!

andrijapanicsb left a comment

Choose a reason for hiding this comment

Uh oh!

andrijapanicsb commented Mar 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

harikrishna-patnala commented Mar 18, 2020 •

edited

Loading