Update vmware reservations description - #3358
Merged
Merged
Conversation
we do NOT always reserve VMware CPU/RAM resources - only when this setting is set to TRUE - verified for both system VMs and user VMs.
Member
|
LGTM @andrijapanicsb should we say in the descripotion that when the global settings are true, the reservation value is considered based on the overprovisioning factors. |
yadvr
approved these changes
May 27, 2019
DaanHoogland
approved these changes
May 27, 2019
Member
|
LGTM, merging based on Travis job#1 because the change is strictly in static string description and does not require full regression test run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we do NOT always reserve VMware CPU/RAM resources - only when "vmware.reserve.cpu" or "vmware.reserve.mem" setting is set to TRUE - AND we do so, irelevant if overprovisioning is active or not. Verified for both system VMs and user VMs.
Description
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
CPU and RAM overprovisioning was active (set to 2.0), while vmware.reserve.cpu and vmware.reserve.mem was set to TRUE or FALSE and the end result was observed in vCenter (6.5).
The same test repeated, with CPU and RAM overprovisioning set to 1.0 (no overprovisioning).