Skip to content

Increase POST timeout for local template upload - #3356

Merged
yadvr merged 2 commits into
masterfrom
andrijapanicsb-patch-1
May 31, 2019
Merged

Increase POST timeout for local template upload#3356
yadvr merged 2 commits into
masterfrom
andrijapanicsb-patch-1

Conversation

@andrijapanicsb

@andrijapanicsb andrijapanicsb commented May 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@andrijapanicsb andrijapanicsb added this to the 4.13.0.0 milestone May 24, 2019
nvazquez
nvazquez approved these changes May 25, 2019
View reviewed changes

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yadvr
yadvr reviewed May 27, 2019
View reviewed changes
Comment thread server/src/main/java/com/cloud/storage/ImageStoreUploadMonitorImpl.java Outdated
static final ConfigKey<Integer> UploadMonitoringInterval = new ConfigKey<Integer>("Advanced", Integer.class, "upload.monitoring.interval", "60",
"Interval (in seconds) to check the status of volumes that are uploaded using HTTP POST request", true);
static final ConfigKey<Integer> UploadOperationTimeout = new ConfigKey<Integer>("Advanced", Integer.class, "upload.operation.timeout", "10",
static final ConfigKey<Integer> UploadOperationTimeout = new ConfigKey<Integer>("Advanced", Integer.class, "upload.operation.timeout", "300",

@yadvr yadvr May 27, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

300 minutes is like 5 hours? How about move to the standard, 1 hour or 60mins?

@yadvr

yadvr commented May 30, 2019

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented May 30, 2019

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 30, 2019

Copy link
Copy Markdown

Packaging result: ✔centos6 ✖centos7 ✔debian. JID-2812

borisstoyanov
borisstoyanov approved these changes May 30, 2019
View reviewed changes

@borisstoyanov borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr

yadvr commented May 30, 2019

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented May 30, 2019

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 30, 2019

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2818

@yadvr

yadvr commented May 30, 2019

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented May 30, 2019

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented May 31, 2019

Copy link
Copy Markdown

Trillian test result (tid-3617)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29171 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3356-t3617-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr
yadvr merged commit fd4309c into master May 31, 2019
@andrijapanicsb
andrijapanicsb deleted the andrijapanicsb-patch-1 branch April 3, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes
@nvazquez nvazquez nvazquez approved these changes
@borisstoyanov borisstoyanov borisstoyanov approved these changes
@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

Assignees

No one assigned

Labels

component:templates type:enhancement

Projects

None yet

Milestone

4.13.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@andrijapanicsb @yadvr @blueorangutan @nvazquez @borisstoyanov @svenvogel