server: add newline to the SSH key content - #3330
Conversation
On first startup, the management server instantiates and saves random ssh keys in the database by calling a `trim()` on the string data. On latest CentOS7 release (CentOS Linux release 7.6.1810 (Core)) I could reproduce the issue where router_proxy (ssh) did not fail and kept prompting for passphrase. By adding a newline to the id_rsa.cloud private key it did not prompt the same. This patch fixes the issue by adding a newline at the end of the generated SSH public/private keys in the DB. SSH packages details: libssh2.x86_64 1.4.3-12.el7_6.2 @updates openssh.x86_64 7.4p1-16.el7 @anaconda openssh-askpass.x86_64 7.4p1-16.el7 @base openssh-clients.x86_64 7.4p1-16.el7 @anaconda openssh-server.x86_64 7.4p1-16.el7 @anaconda Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2737 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2738 |
| } | ||
| // try to patch and SSH into the systemvm for up to 5 minutes | ||
| for (int count = 0; count < 10; count++) { | ||
| for (int count = 0; count < 30; count++) { |
There was a problem hiding this comment.
should the comment above be updated to read "up to 15 minutes"?
There was a problem hiding this comment.
@rhtyd is this change part of this commit ?
|
Trillian test result (tid-3555)
|
|
I'll re-test using a fresh centos7 based env. I hit the problem again today, this time with virtual routers but not ssvm/cpvm with this PR. It's probably something to do openssh-client changes or possibly my env. |
|
I've developed a better fix, will send a new PR. |
|
@ustcweizhou opened a new PR with more explanation here: #3333 I also included a fix to ensure that ssh works on VR in case patching takes more time than anticipated. |
5 participants
On first startup, the management server instantiates and saves random
ssh keys in the database by calling a
trim()on the string data. Onlatest CentOS7 release (CentOS Linux release 7.6.1810 (Core)) I could
reproduce the issue where router_proxy (ssh) failed and kept
prompting for passphrase. By adding a newline to the id_rsa.cloud private
key it did not prompt the same. This may likely be an environmental bug.
The patch fixes the issue by adding a newline at the end of the generated
SSH public/private keys in the DB.
SSH packages details:
libssh2.x86_64 1.4.3-12.el7_6.2 @updates
openssh.x86_64 7.4p1-16.el7 @anaconda
openssh-askpass.x86_64 7.4p1-16.el7 @base
openssh-clients.x86_64 7.4p1-16.el7 @anaconda
openssh-server.x86_64 7.4p1-16.el7 @anaconda
Types of changes