Bug fix for zone names not appearing in dashboard - #3326
Conversation
3 years ago when we moved from JSP this translate was not wrapped in label tags and consequently the following span wasn't captured when dashboard.js mapped the data. Fixes: apache#3314
|
@rhtyd , @resmo , @rafaelweingartner , @DaanHoogland , @DagSonsteboSB , @shwstppr - please take a look when convenient. |
|
makes sense, @anuragaw does this need to go to older versions as well? if so please base on the older branch and we'll merge forward. (/cc @rhtyd @DagSonsteboSB and @Others) |
|
Purely UI change, screenshot and testing is OK, no explicit integration smoketests required. |
|
@rhtyd shouyldn't this have gone into branches 4.11 and 4.12 as well? |
|
@DaanHoogland - I will follow up on this and if needed we can cherry-pick on 4.12. Although I don't know if it is that critical bug. Will wait on folks to comment. |
|
a bug doesn't have to be critical to be fixed in an older version. It only has to be critical to be accepted during release freeze, @anuragaw . If it is not serious enough or has good work-arounds we can now just leave it at this. thanks. |
3 years ago when we moved from JSP this translate was not wrapped in label tags and consequently the following span wasn't captured when dashboard.js mapped the data.
Fixes: #3314
Description
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Through UI