Skip to content

Bug fix for zone names not appearing in dashboard - #3326

Merged
yadvr merged 1 commit into
apache:masterfrom
anuragaw:zone_names_in_dash
May 15, 2019
Merged

Bug fix for zone names not appearing in dashboard#3326
yadvr merged 1 commit into
apache:masterfrom
anuragaw:zone_names_in_dash

Conversation

@anuragaw

Copy link
Copy Markdown
Contributor

3 years ago when we moved from JSP this translate was not wrapped in label tags and consequently the following span wasn't captured when dashboard.js mapped the data.

Fixes: #3314

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Screenshot from 2019-05-10 17-20-06

How Has This Been Tested?

Through UI

3 years ago when we moved from JSP this translate was not wrapped
in label tags and consequently the following span wasn't captured
when dashboard.js mapped the data.

Fixes: apache#3314
@anuragaw

Copy link
Copy Markdown
Contributor Author

@rhtyd , @resmo , @rafaelweingartner , @DaanHoogland , @DagSonsteboSB , @shwstppr - please take a look when convenient.

@DaanHoogland

Copy link
Copy Markdown
Contributor

makes sense, @anuragaw does this need to go to older versions as well? if so please base on the older branch and we'll merge forward. (/cc @rhtyd @DagSonsteboSB and @Others)

@yadvr yadvr added this to the 4.13.0.0 milestone May 15, 2019
@yadvr
yadvr merged commit 3e64285 into apache:master May 15, 2019
@yadvr

yadvr commented May 15, 2019

Copy link
Copy Markdown
Member

Purely UI change, screenshot and testing is OK, no explicit integration smoketests required.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@rhtyd shouyldn't this have gone into branches 4.11 and 4.12 as well?

@anuragaw

Copy link
Copy Markdown
Contributor Author

@DaanHoogland - I will follow up on this and if needed we can cherry-pick on 4.12. Although I don't know if it is that critical bug. Will wait on folks to comment.
CC/ @rhtyd , @rafaelweingartner , @borisstoyanov

@DaanHoogland

Copy link
Copy Markdown
Contributor

a bug doesn't have to be critical to be fixed in an older version. It only has to be critical to be accepted during release freeze, @anuragaw . If it is not serious enough or has good work-arounds we can now just leave it at this. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zone names missing in GUI dashboard in ACS411

7 participants