ajusting dict to pass on if tests later on code, in this way arping i… by lhmachado · Pull Request #2806 · apache/cloudstack

lhmachado · 2018-08-14T14:20:26Z

…s not called anyway.

Description

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

#2805

Screenshots (if appropriate):

How Has This Been Tested?

Manually

Checklist:

I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
Testing
I have added tests to cover my changes.
All relevant new and existing integration tests have passed.
A full integration testsuite with all test that can run on my environment has passed.

yadvr · 2018-08-16T12:27:43Z

@lhmachado can you rebase against 4.11 branch and change base branch of the PR to 4.11?

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2018-08-20T09:58:15Z

@lhmachado I've fixed the rebase issue now.
@blueorangutan package

DaanHoogland · 2018-08-20T10:26:28Z

guess I stopped the ape
@blueorangutan package

blueorangutan · 2018-08-20T10:26:59Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-08-20T10:59:49Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2260

yadvr · 2018-08-21T10:26:29Z

@blueorangutan test matrix

blueorangutan · 2018-08-21T10:26:59Z

@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

wido · 2018-08-21T11:32:01Z

                    dp['gateway'] = self.qFile.data['cmd_line']['localgw']
                else:
-                    dp['gateway'] = 'None'
+                    dp['gateway'] = ''


Why not use None instead of a empty string? Because None is the best way in Python to tell it's empty and does not contain anything.

yes, or 'None' (in a string) I thought I commented that but cannot find my remarks.

ah made it on the ticket instead of here #2805

@wido later on code, there is a string literal concatenation, so if we use None (Type), will raise an "TypeError: cannot concatenate 'str' and 'NoneType' objects".

In python the '' also represent emptyness in if steatements, for this reason in this particular case i`ve used '' instead None (type) .

ok, good point. So either this (less code) or a check on the gateway later to prevent the faulty concat. I can live with this solution. @wido?

I'm okay with the change.

blueorangutan · 2018-08-21T19:28:48Z

Trillian test result (tid-2945)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30545 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2806-t2945-xenserver-71.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:teardown	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_01_scale_vm	`Error`	23.50	test_scale_vm.py

blueorangutan · 2018-08-21T22:48:06Z

Trillian test result (tid-2947)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42871 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2806-t2947-vmware-65.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:teardown	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_05_rvpc_multi_tiers	`Failure`	527.18	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	562.33	test_vpc_redundant.py

blueorangutan · 2018-08-24T01:46:25Z

Trillian test result (tid-2960)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52806 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2806-t2960-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 61 look OK, 6 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	267.78	test_internal_lb.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	1336.70	test_privategw_acl.py
test_02_unsecure_vm_migration	`Error`	445.46	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	357.09	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	233.19	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	315.66	test_vm_life_cycle.py
test_02_redundant_VPC_default_routes	`Failure`	318.19	test_vpc_redundant.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	3.64	test_host_maintenance.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	1.88	test_hostha_kvm.py

yadvr · 2018-08-27T08:21:41Z

@blueorangutan package

blueorangutan · 2018-08-27T08:22:01Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr · 2018-08-27T11:09:17Z

@blueorangutan test

blueorangutan · 2018-08-27T11:10:01Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-08-27T20:25:07Z

Trillian test result (tid-2966)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31647 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2806-t2966-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	1310.74	test_privategw_acl.py
test_02_unsecure_vm_migration	`Error`	64.33	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	43.60	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	49.77	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	1.07	test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	2.42	test_hostha_kvm.py

yadvr · 2018-08-28T10:26:07Z

Tests LGTM, I'm okay with the fix for the release. For longer term, a thorough refactoring and checking of the VR/python code is needed.

yadvr added this to the 4.11.2.0 milestone Aug 16, 2018

yadvr changed the base branch from master to 4.11 August 16, 2018 12:27

yadvr changed the base branch from 4.11 to master August 16, 2018 12:27

lhmachado changed the base branch from master to 4.11 August 17, 2018 18:26

lhmachado changed the base branch from 4.11 to master August 17, 2018 18:26

lhmachado changed the base branch from master to 4.11 August 18, 2018 01:31

lhmachado changed the base branch from 4.11 to master August 18, 2018 01:31

yadvr changed the base branch from master to 4.11 August 20, 2018 09:53

yadvr changed the base branch from 4.11 to master August 20, 2018 09:54

systemvm: Set gateway to empty than None to avoid arping

709db55

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr force-pushed the router_start_arping_bug branch from 644b45c to 709db55 Compare August 20, 2018 09:57

yadvr changed the base branch from master to 4.11 August 20, 2018 09:57

yadvr requested review from DaanHoogland, GabrielBrascher, nvazquez, rafaelweingartner and wido August 20, 2018 09:58

DaanHoogland approved these changes Aug 20, 2018

View reviewed changes

lhmachado mentioned this pull request Aug 20, 2018

Start timeout - Virtual router #2805

Closed

wido reviewed Aug 21, 2018

View reviewed changes

yadvr approved these changes Aug 28, 2018

View reviewed changes

yadvr merged commit 3212ce5 into apache:4.11 Aug 28, 2018

Uh oh!

Conversation

lhmachado commented Aug 14, 2018

Description

Types of changes

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

Uh oh!

yadvr commented Aug 16, 2018

Uh oh!

yadvr commented Aug 20, 2018

Uh oh!

DaanHoogland commented Aug 20, 2018

Uh oh!

blueorangutan commented Aug 20, 2018

Uh oh!

blueorangutan commented Aug 20, 2018

Uh oh!

yadvr commented Aug 21, 2018

Uh oh!

blueorangutan commented Aug 21, 2018

Uh oh!

wido Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Aug 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lhmachado Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

yadvr Aug 28, 2018

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Aug 21, 2018

Uh oh!

blueorangutan commented Aug 21, 2018

Uh oh!

blueorangutan commented Aug 24, 2018

Uh oh!

yadvr commented Aug 27, 2018

Uh oh!

blueorangutan commented Aug 27, 2018

Uh oh!

yadvr commented Aug 27, 2018

Uh oh!

blueorangutan commented Aug 27, 2018

Uh oh!

blueorangutan commented Aug 27, 2018

Uh oh!

yadvr commented Aug 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DaanHoogland Aug 21, 2018 •

edited

Loading