xenserver: Add support for XS 7.3, 7.4 and XCP-ng 7.4 - #2605
Conversation
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1969 |
|
@blueorangutan package |
|
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1970 |
|
/cc @dagsonstebo |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1971 |
|
@blueorangutan test centos xenserver-71 |
|
@rhtyd unsupported parameters provided. Supported mgmt server os are: |
|
@blueorangutan test centos7 xenserver-71 |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests |
|
Trillian test result (tid-2538)
|
|
Trillian test result (tid-2535)
|
|
Trillian test result (tid-2539)
|
|
@blueorangutan test centos7 xenserver-65sp1 |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests |
This adds support for XenServer 7.3 and 7.4, and XCP-ng 7.4 version as hypervisor hosts. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
Trillian test result (tid-2541)
|
|
|
||
| // guest-tools.iso for XenServer version 7.0+ | ||
| if (xenBrand.equals("XenServer") && Integer.parseInt(items[0]) >= 7) { | ||
| if ((xenBrand.equals("XenServer") || xenBrand.equals("XCP-ng")) && Integer.parseInt(items[0]) >= 7) { |
There was a problem hiding this comment.
just a comment; how about defining applicable targets as a set for readability.
Also, though it doesn't apply to this PR, parsing an it is not a very prozaic way of saying you need to be at version 7 or higher. that comment at 2651 should have been a method name instead of a comment
There was a problem hiding this comment.
Not sure how to address this, I'll let it be for this PR.
|
one concern though, the number of failures, even when they seem unrelated at first sight, is concerning. I'll give them a little look later today, please do as well @rhtyd @borisstoyanov ? |
|
@DaanHoogland I compared the failures in this PR against 4.11 smoketest health run: #2376. The errors seems to env related, in case of (a) vm_life_cycle test failures, they are due to secure/non-secure test cases run on xenserver which only apply for KVM, they should be skipped for non-KVM hypervisors ( /cc @borisstoyanov - can you open a PR to ensure that we skip the secure/non-secure migration related tests cases for non-KVM hosts?). Given about analysis, I don't see any real failures caused by this PR. I'll address some of the mentioned failures (a)-(d) in separate 4.11 stabilization PR, with that I'll merge this based on review and tests. |
|
@rhtyd thankssss for the failure analysis. no issues there |
6 participants
This adds support for XenServer 7.3 and 7.4, and XCP-ng 7.4 version
as hypervisor hosts. Fixes #2523.
This also fixes the issue of 4.11 VRs stuck in starting for up-to 10mins, before they come up online. /cc @resmo @mike-tutkowski
Types of changes
GitHub Issue/PRs
Screenshots (if appropriate):
How Has This Been Tested?
Checklist:
Testing