Skip to content

Remove 'md5Hashed' variable from Javascript. - #2555

Merged
DaanHoogland merged 1 commit into
apache:masterfrom
rafaelweingartner:removeMd5HashedVariable
Apr 13, 2018
Merged

Remove 'md5Hashed' variable from Javascript.#2555
DaanHoogland merged 1 commit into
apache:masterfrom
rafaelweingartner:removeMd5HashedVariable

Conversation

@rafaelweingartner

@rafaelweingartner rafaelweingartner commented Apr 9, 2018

Copy link
Copy Markdown
Member

Description

We no longer hash password in the user side. All of the password processing is executed in the server side according to the priority of hashing mechanism defined by the administrator.

Mailing list discussion thread: https://lists.apache.org/thread.html/75f0d8910a70c1f81952a0db023d4111e1d3164eb00a159c51f7b719@%3Cdev.cloudstack.apache.org%3E

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

Locally.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@blueorangutan package

We no longer hash password in the user side. All of the password processing is executed in the server side according to the priority of hashing mechanism defined by the administrator.
@rafaelweingartner rafaelweingartner self-assigned this Apr 9, 2018
@rafaelweingartner rafaelweingartner added this to the 4.12.0.0 milestone Apr 9, 2018
@blueorangutan

Copy link
Copy Markdown

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1893

var ERROR_VMOPS_ACCOUNT_ERROR = 531;

// Default password is MD5 hashed. Set the following variable to false to disable this.
var md5Hashed = false;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafaelweingartner while this PR LGTM, we may need to discuss with user/dev@ as this variable may be set by a UI plugin that is not opensource or with the upstream tree? Certain parts of the code may exist and appear to be not used at all, but may be used by an external UI/backend plugin.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will ask people in the mailing list then. If there is no objections there, I think we can proceed.

@borisstoyanov borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland
DaanHoogland merged commit d23f4b0 into apache:master Apr 13, 2018
@blueorangutan

Copy link
Copy Markdown

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1916

julien-vaz pushed a commit to scclouds/cloudstack that referenced this pull request Feb 18, 2025
Remoção da validação da quantidade de IPs públicos alocados para uma conta durante a adição de regras de _port forwarding_, _load balancing_ e ativação de _static_ NAT

Closes apache#2555

See merge request scclouds/scclouds!1123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants