debian: remove old usage jars during upgrade - #2552
Merged
Merged
Conversation
This removes old cloudstack-usage jars during upgrade as part of the pre-install step of cloudstack-usage deb package. This fixes apache#2542 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1887 |
DaanHoogland
approved these changes
Apr 8, 2018
DaanHoogland
left a comment
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
looks good, but why only on upgrade, can we do this on uninstall/remove as well?
Member
Author
|
@DaanHoogland thanks, I've kept the changes limited to address the issue #2542 Ideally, all the files installed by the package should be removed during upgrade or removal/uninstall. |
Contributor
|
ok, @rhtyd |
rafaelweingartner
approved these changes
Apr 9, 2018
Member
Author
|
Upgrade test is not done by Trillian, tested upgrade manually on Ubuntu xenial 16.04. Seems working okay for me. I'll merge this based on reviews and manual upgrade test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes old cloudstack-usage jars during upgrade as part of
the pre-install step of cloudstack-usage deb package.
This fixes #2542
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist:
Testing
@blueorangutan package