fix typo c&p bug in externalId feature UI

[DaanHoogland]

closes issue #2533

Description

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
  Testing
• I have added tests to cover my changes.
• All relevant new and existing integration tests have passed.
• A full integration testsuite with all test that can run on my environment has passed.

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1876

[rafaelweingartner]

I checked the server side code. And indeed if the netmask is not provided we ignore the guestGateway value. This makes ACS to use the default value.

[nitin-maharana]

@DaanHoogland, Thanks for the fix. @rafaelweingartner, I just had a look at the code. Everywhere the check for netmask is performed with the gateway only (gateway != null && netmask != null), but I couldn't able to figure out, how ACS picks the default value if it is null.

[yadvr]

@DaanHoogland can you add a screenshot to show that some testing was done, then we can merge this.

[rafaelweingartner]

@rhtyd Do we really need a screenshot here? Looking at the code it is clear the problem and how it was fixed.

What do you think @DaanHoogland?

[yadvr]

Sure, @rafaelweingartner we can accept this without explicit screenshot. In which case I'll merge this.

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✖centos7 ✔debian. JID-1973

[DaanHoogland]

sorry @rhtyd and @rafaelweingartner I didn't look at adding the screen shot. I'm not sure twhat i would have been adding. probably the lack of an error but it was tested by a colleague.