make Broadcast- and IsolationURI visible to admin - #2520
Merged
Conversation
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
rafaelweingartner
approved these changes
Apr 2, 2018
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1865 |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1866 |
borisstoyanov
approved these changes
Apr 2, 2018
borisstoyanov
left a comment
borisstoyanov
left a comment
Contributor
There was a problem hiding this comment.
LGTM, no need for integration tests since this is a UI change only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As an admin /me wants to have easy access the broadcast uri ad the isolation uri used for a nic. these fields were missing in the UI while available in the API.
This can be argued to not be a bug, but it is a trivial fix of an old ommision, so feel free to argue it should't go in 4.11.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
tested this by creating a user in the simulator and let it create a VM. Next view the NICs tab of the VM as normal user and as admin. The proof is in the screenshots.
Checklist:
@blueorangutan package