Skip to content

use ConfigKeys for ManagementServer, agent, secondary storage and router settings - #14474

Open
DaanHoogland wants to merge 1 commit into
ghi10752-config-core-1from
ghi10752-config-core-2
Open

use ConfigKeys for ManagementServer, agent, secondary storage and router settings#14474
DaanHoogland wants to merge 1 commit into
ghi10752-config-core-1from
ghi10752-config-core-2

use ConfigKeys for ManagementServer, agent, secondary storage and rou…

149bbda
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 28, 2026 in 7m 3s

Quality Gate failed

Failed conditions
5.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 580 in server/src/main/java/com/cloud/server/ConfigurationServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFkGwSKs5GkW_Zvs1Hw&open=AaFkGwSKs5GkW_Zvs1Hw&pullRequest=14474

Check warning on line 882 in server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFkGwjes5GkW_Zvs1H1&open=AaFkGwjes5GkW_Zvs1H1&pullRequest=14474

Check failure on line 182 in server/src/main/java/com/cloud/server/ConfigurationServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFkGwSKs5GkW_Zvs1Hx&open=AaFkGwSKs5GkW_Zvs1Hx&pullRequest=14474

Check warning on line 887 in server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFkGwjes5GkW_Zvs1H2&open=AaFkGwjes5GkW_Zvs1H2&pullRequest=14474

Check warning on line 880 in server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFkGwjes5GkW_Zvs1H0&open=AaFkGwjes5GkW_Zvs1H0&pullRequest=14474

Check warning on line 1181 in services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFkGwpss5GkW_Zvs1H3&open=AaFkGwpss5GkW_Zvs1H3&pullRequest=14474

Check warning on line 1921 in server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFkGwMKs5GkW_Zvs1Hv&open=AaFkGwMKs5GkW_Zvs1Hv&pullRequest=14474

Check warning on line 1555 in server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFkGwf8s5GkW_Zvs1Hz&open=AaFkGwf8s5GkW_Zvs1Hz&pullRequest=14474

Check warning on line 198 in plugins/network-elements/internal-loadbalancer/src/main/java/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFkGv8es5GkW_Zvs1Hu&open=AaFkGv8es5GkW_Zvs1Hu&pullRequest=14474

Check warning on line 1221 in server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFkGwUUs5GkW_Zvs1Hy&open=AaFkGwUUs5GkW_Zvs1Hy&pullRequest=14474
View more details on SonarQubeCloud