Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14403 +/- ##
============================================
+ Coverage 19.91% 20.21% +0.29%
- Complexity 20200 20749 +549
============================================
Files 6373 6426 +53
Lines 577230 580191 +2961
Branches 70696 71034 +338
============================================
+ Hits 114974 117291 +2317
- Misses 449690 450186 +496
- Partials 12566 12714 +148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Damans227
reviewed
Oct 14, 2026
| ArrayList<String> failedChecks = new ArrayList<>(); | ||
| for (String failedCheckName : failingChecks) { | ||
| RouterHealthCheckResultVO routerHealthCheckResultVO = routerHealthCheckResultDao.getRouterHealthCheckResult(router.getId(), failedCheckName, null); | ||
| String failedCheckDetails = routerHealthCheckResultVO.getParsedCheckDetails(); |
Collaborator
There was a problem hiding this comment.
what happens if there is no saved result for a failing check? looks like it crashes here and the router recreate and the other routers get skipped
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When one or more VR health checks fail and alert notifications are configured in the environment, an email that does not include details about which tests failed is sent. The message has been rewritten to display which health checks have failed.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Alert received
How Has This Been Tested?
Build the packages and installed them. Then, I created a new Isolated network and deploy a VM on it. The VR was accessed by console and the
openssh-serverpackage was purged. After that, I requested for fresh checks. As it could not access the VR via SSH, all the tests failed and an email was sent informing about the failure to access the Instance (image attached to the Screenshots section)