Skip to content

Fixes VM snapshot usage records that are attributed to the old snapshot - #14308

Draft
harikrishna-patnala wants to merge 1 commit into
apache:4.22from
shapeblue:vm-snapshot-usage-fix
Draft

harikrishna-patnala wants to merge 1 commit into
apache:4.22from
shapeblue:vm-snapshot-usage-fix

Conversation

@harikrishna-patnala

@harikrishna-patnala harikrishna-patnala commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Description

This PR fixes #13921

Here we used the right usage record to get the actual snapshot details.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.00%. Comparing base (2e63c60) to head (0d25a22).

Files with missing lines Patch % Lines
.../com/cloud/usage/parser/VMSnapshotUsageParser.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #14308   +/-   ##
=========================================
  Coverage     18.00%   18.00%           
- Complexity    16219    16220    +1     
=========================================
  Files          5936     5936           
  Lines        535716   535716           
  Branches      65596    65596           
=========================================
  Hits          96459    96459           
+ Misses       428268   428266    -2     
- Partials      10989    10991    +2     
Flag Coverage Δ
uitests 4.02% <ø> (ø)
unittests 19.08% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code makes sense

@harikrishna-patnala
harikrishna-patnala marked this pull request as draft October 5, 2026 09:21

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VM snapshot usage records are attributed to the wrong snapshot; older snapshots stop accruing usage entirely

2 participants