Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14224 +/- ##
============================================
+ Coverage 19.91% 20.21% +0.29%
- Complexity 20200 20749 +549
============================================
Files 6373 6426 +53
Lines 577230 580177 +2947
Branches 70696 71028 +332
============================================
+ Hits 114974 117294 +2320
- Misses 449690 450170 +480
- Partials 12566 12713 +147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 7
Open (10)
maskSensitiveInfoInXML(xmlDesc)is evaluated eagerly even when DEBUG is disabled, which can be… · NewmaskSensitiveInfoInXML(xmlDesc)is evaluated eagerly even when DEBUG is disabled, which can be… · NewmaskSensitiveInfoInXML(xmlDesc)is evaluated eagerly even when DEBUG is disabled, which can be… · NewmaskSensitiveInfoInXML(xmlDesc)is evaluated eagerly even when DEBUG is disabled, which can be… · Newe.getMessage()and drop the stack trace, which makes… · Newe.getMessage()and drop the stack trace, which makes… · Newe.getMessage()and drop the stack trace, which makes… · NewString.valueOf(migrateDowntime)is unnecessary for parameterized logging (it will be converted… · New
What changed in this PR
Refactors KVM VM migration logging to be more consistent and contextual, primarily by switching to parameterized logging and standardizing messages for troubleshooting.
Changes:
- Replaced
String.format/string concatenation with parameterized logging across KVM migration flow. - Expanded log context (destination host, XML retrieval flag, job stats) for better traceability.
- Tweaked log levels/messages around migration timeouts and exception handling.
| File | Description |
|---|---|
| plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java | Standardizes and enriches migration logs; adjusts log levels and message structure. |
| engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java | Fixes/standardizes config-drive detach logging and improves message quality. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
erikbocks
changed the title
Damans227
reviewed
Oct 13, 2026
Collaborator
|
thanks @erikbocks, log changes look right. LGTM |
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
4 open findings
e.getMessage()and the exceptione. Since the throwable is already passed,… · New
10 resolved since last review
e.getMessage()and drop the stack trace, which makes…e.getMessage()and drop the stack trace, which makes…e.getMessage()and drop the stack trace, which makes…maskSensitiveInfoInXML(xmlDesc)is evaluated eagerly even when DEBUG is disabled, which can be…maskSensitiveInfoInXML(xmlDesc)is evaluated eagerly even when DEBUG is disabled, which can be…maskSensitiveInfoInXML(xmlDesc)is evaluated eagerly even when DEBUG is disabled, which can be…maskSensitiveInfoInXML(xmlDesc)is evaluated eagerly even when DEBUG is disabled, which can be…String.valueOf(migrateDowntime)is unnecessary for parameterized logging (it will be converted…
🧠 Review effort: Lite
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
3 open findings
4 resolved since last review
e.getMessage()and the exceptione. Since the throwable is already passed,…
🧠 Review effort: Lite
| logger.error("TIme out occurred while exeuting command AttachOrDettachConfigDrive {}", e.getMessage(), e); | ||
|
|
||
| } | ||
| logger.error("Timeout occurred while executing command AttachOrDettachConfigDrive for VM {} on source host {}", vm.getInstanceName(), srcHost.getId(), e); } |
| logger.info("VM domain state when trying to pause VM for migration: {}.", state); | ||
| } catch (final LibvirtException e) { | ||
| logger.info("Couldn't get VM domain state after " + sleeptime + "ms: " + e.getMessage()); | ||
| logger.info("Could not get VM domain state after {}ms: {}.", sleeptime, e.getMessage()); |
| } | ||
|
|
||
| private void logMigrationFailure(String vmName, String destinationIp, Exception exception) { | ||
| logger.error("Could not migrate domain [{}] to host [{}].", vmName, destinationIp, exception); |
Copilot stopped reviewing on behalf of
erikbocks due to an error
October 13, 2026 18:53
Copilot stopped reviewing on behalf of
erikbocks due to an error
October 13, 2026 19:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on improving the consistency and clarity of logging of the KVM VM migration process. The changes aim to improve the traceability of the process, by adding more context for the logs, helping future troubleshooting processes. It also standardizes log messages to use parametrized logging, instead of string concatenation.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
The code was compiled with Maven and installed to my local environment. Then, I migrated a VM from one of my hosts to another and verified that the new logs were displayed correctly.