Skip to content

no quiescense when doing vm snapshot on individual disks #13941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DaanHoogland wants to merge 1 commit into
base: 4.20
Choose a base branch
from
+7 −6
Draft

no quiescense when doing vm snapshot on individual disks #13941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions ...hot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/StorageVMSnapshotStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,18 +423,19 @@ protected void revertDiskSnapshot(VMSnapshot vmSnapshot) {
}
}

/**
* Creates a disk (volume) snapshot for one volume of a VM snapshot in progress.
* The payload is always given {@code quiescevm=false}: by this point the whole VM is
* already frozen via {@link FreezeThawVMCommand}, and {@code DefaultSnapshotStrategy}
* rejects {@code quiescevm=true} for volume snapshots.
*/
protected SnapshotInfo createDiskSnapshot(VMSnapshot vmSnapshot, List<SnapshotInfo> forRollback, VolumeInfo vol) {
String snapshotName = vmSnapshot.getId() + "_" + vol.getUuid();
SnapshotVO snapshot = new SnapshotVO(vol.getDataCenterId(), vol.getAccountId(), vol.getDomainId(), vol.getId(), vol.getDiskOfferingId(),
snapshotName, (short) Snapshot.Type.GROUP.ordinal(), Snapshot.Type.GROUP.name(), vol.getSize(), vol.getMinIops(), vol.getMaxIops(), Hypervisor.HypervisorType.KVM, null);
VMSnapshotOptions options = ((VMSnapshotVO) vmSnapshot).getOptions();
boolean quiescevm = false;
if (options != null) {
quiescevm = options.needQuiesceVM();
}

snapshot = snapshotDao.persist(snapshot);
vol.addPayload(setPayload(vol, snapshot, quiescevm));
vol.addPayload(setPayload(vol, snapshot, false));
SnapshotInfo snapshotInfo = snapshotDataFactory.getSnapshot(snapshot.getId(), vol.getDataStore());
snapshotInfo.addPayload(vol.getpayload());
SnapshotStrategy snapshotStrategy = storageStrategyFactory.getSnapshotStrategy(snapshotInfo, SnapshotOperation.TAKE);
Expand Down
Loading