allow MS to start when DB version is behind by a NoOp upgrade step

[DaanHoogland]

Description

This PR fixes the situation where a second MS won’t start because another one is running and the DB version is behind by only a NoOp upgrade step. This causes problems for all but the first MS in situations where the last step is not reflected in the DB.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.33%. Comparing base (6136ac9) to head (ba363db).

Files with missing lines	Patch %	Lines
...java/com/cloud/upgrade/DatabaseUpgradeChecker.java	76.92%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #13928      +/-   ##
============================================
+ Coverage     16.32%   16.33%   +0.01%     
- Complexity    13556    13564       +8     
============================================
  Files          5669     5669              
  Lines        501399   501404       +5     
  Branches      60902    60902              
============================================
+ Hits          81847    81899      +52     
+ Misses       410390   410339      -51     
- Partials       9162     9166       +4     

Flag	Coverage Δ
uitests	4.14% <ø> (ø)
unittests	17.19% <76.92%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
70.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18925

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[weizhouapache]

@DaanHoogland
Just had a second thought: this would allow mgmt2 to start while mgmt1 is still running an older version (with no actual DB upgrade), resulting in mgmt1 and mgmt2 running different versions at the same time. Is it good ?

[DaanHoogland]

No, @weizhouapache I think the original fists did it's work as intended and this change may be harmful

[weizhouapache]

No, @weizhouapache I think the original fists did it's work as intended and this change may be harmful

agree. shall we close this PR or keep it as draft ?

[DaanHoogland]

there’s your answer ;)