Skip to content

Fix and de-risk UserVmManagerImpl external-DHCP startup scan - #13635

Draft
Pearl1594 wants to merge 3 commits into
4.20from
externaldhcp-startup-uservm
Draft

Fix and de-risk UserVmManagerImpl external-DHCP startup scan#13635
Pearl1594 wants to merge 3 commits into
4.20from
externaldhcp-startup-uservm

Restore L2 network scanning in external-DHCP startup seed

eca8eb5
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 20, 2026 in 8m 48s

Annotations

Check warning on line 3254 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAgA5Rpzx3yvrMJTarO&open=AaAgA5Rpzx3yvrMJTarO&pullRequest=13635

Check warning on line 241 in server/src/test/java/com/cloud/network/NetworkModelImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAgA5PQzx3yvrMJTarN&open=AaAgA5PQzx3yvrMJTarN&pullRequest=13635

Check warning on line 3296 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAgA5Rpzx3yvrMJTarT&open=AaAgA5Rpzx3yvrMJTarT&pullRequest=13635

Check warning on line 3255 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAgA5Rpzx3yvrMJTarP&open=AaAgA5Rpzx3yvrMJTarP&pullRequest=13635

Check warning on line 3255 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAgA5Rpzx3yvrMJTarQ&open=AaAgA5Rpzx3yvrMJTarQ&pullRequest=13635

Check warning on line 3283 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAgA5Rpzx3yvrMJTarR&open=AaAgA5Rpzx3yvrMJTarR&pullRequest=13635

Check warning on line 3297 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAgA5Rpzx3yvrMJTarU&open=AaAgA5Rpzx3yvrMJTarU&pullRequest=13635

Check warning on line 2479 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAgA5Jdzx3yvrMJTarL&open=AaAgA5Jdzx3yvrMJTarL&pullRequest=13635

Check warning on line 3297 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAgA5Rpzx3yvrMJTarV&open=AaAgA5Rpzx3yvrMJTarV&pullRequest=13635

Check warning on line 239 in server/src/test/java/com/cloud/network/NetworkModelImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAgA5PQzx3yvrMJTarM&open=AaAgA5PQzx3yvrMJTarM&pullRequest=13635

Check warning on line 3283 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAgA5Rpzx3yvrMJTarS&open=AaAgA5Rpzx3yvrMJTarS&pullRequest=13635