fix: scan all service provider elements before failing the lookup

[rootnomad]

Description

virtualRouterElementState and internalLbVmElementState look up the service provider element by iterating the list returned by the API, but the not-found error was returned inside the loop:

for _, e := range vre.VirtualRouterElements {
    if nsp.Id == e.Nspid {
        vreID = e.Id
        break
    }
    return fmt.Errorf("Service provider element id (nspod) not found: %s.", nsp.Id)
}

So the lookup fails on the first element that does not match instead of scanning the rest, and an empty list falls through with an empty id into ConfigureVirtualRouterElement. Move the error after the loop behind an empty-id check, so every element is scanned and a genuinely missing element returns a clear error. Same fix for the internal LB element lookup.

Testing

go build ./..., go vet ./... and go test ./cloudstack/ pass (the resource's acceptance test skips without TF_ACC).

There is no fails-before/passes-after acceptance test here: in a standard zone each provider has a single element, so the early return is not reached and the bug does not manifest end to end. The change is a localized control-flow correction in the element lookup, verified by the build, vet and the existing suite.

[Copilot]

🟢 Approval recommended

The localized changes correctly handle later matches and empty result sets without introducing regressions.

0 open findings

What changed in this PR

Corrects service-provider element lookups so all API results are searched before reporting failure.

Changes:

• Scans all virtual-router and internal-LB elements.
• Rejects missing or empty element IDs before configuration.

File	Description
cloudstack/​resource_cloudstack_network_service_provider_state.go	Corrects element lookup control flow.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.