Skip to content

Refactor analyze for PAX#1440

Open
gfphoenix78 wants to merge 2 commits into
apache:mainfrom
gfphoenix78:pax-analyze
Open

Refactor analyze for PAX#1440
gfphoenix78 wants to merge 2 commits into
apache:mainfrom
gfphoenix78:pax-analyze

Conversation

@gfphoenix78

Copy link
Copy Markdown
Contributor

Refactor analyze logic for PAX like AOCO.

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@my-ship-it

Copy link
Copy Markdown
Contributor

Thank you for filing the PR.
Compared to the previous PAX analyze logic, does our new implementation method have performance improvements?

@yjhjstz

yjhjstz commented Nov 19, 2025

Copy link
Copy Markdown
Member

AO/CO ANALYZE sampling by combining Knuth's Algorithm S and varblock skipping in this patch

please refer to 3807ca3

@gfphoenix78

Copy link
Copy Markdown
Contributor Author

AO/CO ANALYZE sampling by combining Knuth's Algorithm S and varblock skipping in this patch

please refer to 3807ca3

The number of sampling tuples is less than targrows if dead tuples are selected.

Comment thread contrib/pax_storage/src/cpp/access/pax_access_handle.cc
@my-ship-it my-ship-it requested a review from reshke January 22, 2026 08:52
Refactor analyze logic for PAX like AOCO.

@my-ship-it my-ship-it left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants