CASSANDRA-21012: Allow CQLSSTableWriter to specify SSTable id type (legacy/uuid) - #5093
Open
arvindKandpal-ksolves wants to merge 4 commits into
Open
CASSANDRA-21012: Allow CQLSSTableWriter to specify SSTable id type (legacy/uuid)#5093arvindKandpal-ksolves wants to merge 4 commits into
arvindKandpal-ksolves wants to merge 4 commits into
Conversation
Contributor
smiklosovic
self-requested a review
September 2, 2026 11:16
smiklosovic
requested changes
Sep 2, 2026
Contributor
Author
|
Thanks for the review, @smiklosovic! Applied the suggested changes. |
smiklosovic
reviewed
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CQLSSTableWriteralways generates SSTables with legacy sequential identifiers. If someone writes SSTables standalone and loads them into a node withuuid_sstable_identifiers_enabled: true(vianodetool refresh), the legacy naming causes a mismatch since it's not converted to UUID format.Fix
Added
withUUIDSSTableIdentifiers(boolean)toCQLSSTableWriter.Builder, letting users explicitly choose legacy or UUID identifiers at build time.Default behavior (unset) falls back to the existing config-flag based logic — fully backward compatible.Changes
SSTableIdFactory: newbuilderFor(boolean)methodAbstractSSTableSimpleWriter: instance-levelidBuilder(static id counterkept as-is for cross-instance uniqueness)
SSTableSimpleWriter/SSTableSimpleUnsortedWriter: new constructor overloadsCQLSSTableWriter.Builder: newwithUUIDSSTableIdentifiers(boolean)methodTesting
CQLSSTableWriterDaemonTest,CQLSSTableWriterClientTest)uuid_sstable_identifiers_enabled: true, rannodetool refresh, confirmed data loaded correctlyant checkstylepassesThe Cassandra Jira