CASSANDRA-18254: sstabledump for secondary index sstable error - #5077
Open
lakshaym7 wants to merge 1 commit into
Open
CASSANDRA-18254: sstabledump for secondary index sstable error#5077lakshaym7 wants to merge 1 commit into
lakshaym7 wants to merge 1 commit into
Conversation
sstabledump threw UnsupportedOperationException when dumping a secondary-index sstable, because PartitionerDefinedOrder.toJSONString always threw. Print the clustering key as raw hex bytes instead, following the approach in CASSANDRA-17698. patch by Lakshay Madan Gopal; reviewed by TBD for CASSANDRA-18254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CASSANDRA-18254
sstabledump threw UnsupportedOperationException when dumping a
secondary-index sstable, because the base table's partition-key column
is carried into the index as a clustering column typed
PartitionerDefinedOrder, whose toJSONString always threw.
This applies the lightweight fix agreed on the ticket for the older
branches: print the failing clustering key as raw hex bytes instead of
throwing, matching the reporter's reference patches (#2167 / #2168) and
following the approach from CASSANDRA-17698. The full type-threading
rework from 17698 is a format-level change and is already applied on 5.0
and later, so this change targets 4.0 (and forward to 4.1).
Testing:
the hex string instead of throwing.
the dump completes with valid JSON and hex-encoded clustering values.