Disable Minio IT tests - #26876
Disable Minio IT tests#26876
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 11 of 695 tested, 3 compile-only — current: 11 all testedMaveniverse Scalpel detected 11 affected modules (current approach: 11). Skip-tests mode would test 11 modules (2 direct + 0 downstream), skip tests for 3 (generated code, meta-modules) Modules Scalpel would test (11)
Modules with tests skipped (3)
All tested modules (38 modules, 5m 31s total)Total reactor time: 5m 31s
Top 20 slowest modules:
|
davsclaus
left a comment
There was a problem hiding this comment.
Thanks Aurélien. This looks good to me. All 7 ITs in the module are covered, and camel-test-infra-minio is only used by camel-minio's own tests, so nothing else is affected.
Two small optional suggestions:
- Could the
@Disabledreason (or the commit message) mention CAMEL-24750, so that someone who finds these later can follow the history? camel-test-infra-minio, and the minio entry thatcamel infra run/ the MCPTestInfraDataexpose, will now point at an image that can't be pulled. Maybe note that on CAMEL-24750 as a follow-up (deprecate/remove the infra service together with the component)?
This review was generated by an AI agent on behalf of davsclaus and may contain inaccuracies. Please verify all suggestions before applying.
MinIO was deprecated in 4.23. The upstream project is closed and container images were aggressively removed from registries. Signed-off-by: Aurélien Pupier <apupier@ibm.com>
Signed-off-by: Aurélien Pupier <apupier@ibm.com>
14df225 to
e34fd15
Compare
gnodet-bot
left a comment
There was a problem hiding this comment.
All 7 MinIO IT classes are covered by @Disabled with a clear reason referencing CAMEL-24750, and all public camel-test-infra-minio service types are marked @Deprecated(since = "4.23"). Both suggestions from the previous review are addressed. No production code changes, no downstream impact. Solid.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
🔄 Backport BotPort PRs created:
Conflicts (🤖 agent dispatched to resolve):
ℹ️ If you push additional commits after |
MinIO was deprecated in 4.23. The upstream project is closed and container images were aggressively removed from registries.
It was removed few weeks ago from DockerHub and gcr.io. It was today from quay.io
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.AI-assisted contributions
Co-authored-bytrailers) and the PR description identifies the AI tool used.