Skip to content

Disable Minio IT tests - #26876

Merged
apupier merged 2 commits into
apache:mainfrom
apupier:deactivateMinioITTests
Sep 28, 2026
Merged

apupier merged 2 commits into
apache:mainfrom
apupier:deactivateMinioITTests

Conversation

@apupier

@apupier apupier commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

MinIO was deprecated in 4.23. The upstream project is closed and container images were aggressively removed from registries.

It was removed few weeks ago from DockerHub and gcr.io. It was today from quay.io

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

AI-assisted contributions

  • If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., Co-authored-by trailers) and the PR description identifies the AI tool used.

@apupier apupier added port/camel-4.22.x Bug needs porting to camel-4.22.x port/camel-4.18.x Bug needs porting to camel-4.18.x labels Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • components/camel-minio
  • test-infra/camel-test-infra-minio

🔬 Scalpel shadow comparison — Scalpel: 11 of 695 tested, 3 compile-only — current: 11 all tested

Maveniverse Scalpel detected 11 affected modules (current approach: 11).

Skip-tests mode would test 11 modules (2 direct + 0 downstream), skip tests for 3 (generated code, meta-modules)

Modules Scalpel would test (11)
  • camel-jbang-mcp ← depends on affected reactor module org.apache.camel:camel-yaml-dsl-validator
  • camel-jbang-plugin-mcp ← depends on affected reactor module org.apache.camel:camel-jbang-core
  • camel-jbang-plugin-route-parser ← depends on affected reactor module org.apache.camel:camel-route-parser
  • camel-jbang-plugin-tui ← depends on affected reactor module org.apache.camel:camel-yaml-dsl-validator
  • camel-jbang-plugin-validate ← depends on affected reactor module org.apache.camel:camel-yaml-dsl-validator
  • camel-launcher-container ← depends on affected reactor module org.apache.camel:camel-launcher
  • camel-minio ← components/camel-minio/src/test/java/org/apache/camel/component/minio/integration/MinioComponentIT.java, components/camel-minio/src/test/java/org/apache/camel/component/minio/integration/MinioConsumerIT.java, components/camel-minio/src/test/java/org/apache/camel/component/minio/integration/MinioDeleteBucketOperationIT.java, components/camel-minio/src/test/java/org/apache/camel/component/minio/integration/MinioListObjectsOperationIT.java, components/camel-minio/src/test/java/org/apache/camel/component/minio/integration/MinioObjectRangeOperationIT.java, components/camel-minio/src/test/java/org/apache/camel/component/minio/integration/MinioPresignedUrlIT.java, components/camel-minio/src/test/java/org/apache/camel/component/minio/integration/MinioPutObjectBodyTypesIT.java
  • camel-test-infra-all ← depends on affected reactor module org.apache.camel:camel-test-infra-minio
  • camel-test-infra-minio ← test-infra/camel-test-infra-minio/src/main/java/org/apache/camel/test/infra/minio/common/MinioProperties.java, test-infra/camel-test-infra-minio/src/main/java/org/apache/camel/test/infra/minio/services/MinioInfraService.java, test-infra/camel-test-infra-minio/src/main/java/org/apache/camel/test/infra/minio/services/MinioLocalContainerInfraService.java, test-infra/camel-test-infra-minio/src/main/java/org/apache/camel/test/infra/minio/services/MinioRemoteInfraService.java, test-infra/camel-test-infra-minio/src/main/java/org/apache/camel/test/infra/minio/services/MinioService.java, test-infra/camel-test-infra-minio/src/main/java/org/apache/camel/test/infra/minio/services/MinioServiceFactory.java, own pom test-infra/camel-test-infra-minio/pom.xml changed
  • camel-yaml-dsl-validator ← depends on affected reactor module org.apache.camel:camel-catalog
  • camel-yaml-dsl-validator-maven-plugin ← depends on affected reactor module org.apache.camel:camel-yaml-dsl-validator
Modules with tests skipped (3)
  • camel-itest
  • camel-yaml-dsl
  • camel-yaml-dsl-deserializers

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (38 modules, 5m 31s total)

Total reactor time: 5m 31s

Module Duration Status
Camel :: Launcher 50.4s SUCCESS
Camel :: JBang :: MCP 39.3s SUCCESS
Camel :: JBang :: Plugin :: TUI 30.0s SUCCESS
Camel :: Component DSL 25.7s SUCCESS
Camel :: Catalog :: Camel Catalog 21.4s SUCCESS
Camel :: Test Infra :: All test services 18.5s SUCCESS
Camel :: YAML DSL 16.2s SUCCESS
Camel :: Docs 14.0s SUCCESS
Camel :: JBang :: Plugin :: Kubernetes 13.3s SUCCESS
Camel :: MinIO (Deprecated) 13.2s SUCCESS
Camel :: Kamelet Main 10.2s SUCCESS
Camel :: YAML DSL :: Validator 9.9s SUCCESS
Camel :: YAML DSL :: Deserializers 7.7s SUCCESS
Camel :: JBang :: Plugin :: Testing 7.7s SUCCESS
Camel :: Catalog :: Camel Route Parser 7.2s SUCCESS
Camel :: Catalog :: Camel Report Maven Plugin 6.1s SUCCESS
Camel :: YAML DSL :: Validator Maven Plugin 5.4s SUCCESS
Camel :: All Components Sync point 4.9s SUCCESS
Camel :: JBang :: Plugin :: Validate 4.8s SUCCESS
Camel :: Test Infra :: Minio (deprecated) 3.9s SUCCESS
Camel :: YAML DSL :: Maven Plugins 3.0s SUCCESS
Camel :: Catalog :: Maven 2.9s SUCCESS
Camel :: Catalog :: Suggest (deprecated) 2.8s SUCCESS
Camel :: Assembly 1.6s SUCCESS
Camel :: JBang :: Plugin :: Edit 1.4s SUCCESS
Camel :: Coverage 1.3s SUCCESS
Camel :: JBang :: Plugin :: MCP 1.1s SUCCESS
Camel :: JBang :: Main 1.1s SUCCESS
Camel :: JBang :: Plugin :: Generate 1.0s SUCCESS
Camel :: JBang :: Integration tests 1.0s SUCCESS
Camel :: Catalog :: Dummy Component 0.9s SUCCESS
Camel :: Catalog :: Console 0.8s SUCCESS
Camel :: Endpoint DSL :: Support 0.7s SUCCESS
Camel :: Launcher :: Container 0.7s SUCCESS
Camel :: JBang :: Plugin :: Route Parser 0.6s SUCCESS
Camel :: Endpoint DSL n/a
Camel :: Integration Tests n/a
Camel :: JBang :: Core n/a

Top 20 slowest modules:

  • Camel :: Launcher (50.4s)
  • Camel :: JBang :: MCP (39.3s)
  • Camel :: JBang :: Plugin :: TUI (30.0s)
  • Camel :: Component DSL (25.7s)
  • Camel :: Catalog :: Camel Catalog (21.4s)
  • Camel :: Test Infra :: All test services (18.5s)
  • Camel :: YAML DSL (16.2s)
  • Camel :: Docs (14.0s)
  • Camel :: JBang :: Plugin :: Kubernetes (13.3s)
  • Camel :: MinIO (Deprecated) (13.2s)
  • Camel :: Kamelet Main (10.2s)
  • Camel :: YAML DSL :: Validator (9.9s)
  • Camel :: YAML DSL :: Deserializers (7.7s)
  • Camel :: JBang :: Plugin :: Testing (7.7s)
  • Camel :: Catalog :: Camel Route Parser (7.2s)
  • Camel :: Catalog :: Camel Report Maven Plugin (6.1s)
  • Camel :: YAML DSL :: Validator Maven Plugin (5.4s)
  • Camel :: All Components Sync point (4.9s)
  • Camel :: JBang :: Plugin :: Validate (4.8s)
  • Camel :: Test Infra :: Minio (deprecated) (3.9s)

⚙️ View full build and test results

@apupier
apupier marked this pull request as ready for review September 25, 2026 07:16

@davsclaus davsclaus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aurélien. This looks good to me. All 7 ITs in the module are covered, and camel-test-infra-minio is only used by camel-minio's own tests, so nothing else is affected.

Two small optional suggestions:

  • Could the @Disabled reason (or the commit message) mention CAMEL-24750, so that someone who finds these later can follow the history?
  • camel-test-infra-minio, and the minio entry that camel infra run / the MCP TestInfraData expose, will now point at an image that can't be pulled. Maybe note that on CAMEL-24750 as a follow-up (deprecate/remove the infra service together with the component)?

This review was generated by an AI agent on behalf of davsclaus and may contain inaccuracies. Please verify all suggestions before applying.

MinIO was deprecated in 4.23. The upstream project is closed and
container images were aggressively removed from registries.

Signed-off-by: Aurélien Pupier <apupier@ibm.com>
Signed-off-by: Aurélien Pupier <apupier@ibm.com>

@gnodet-bot gnodet-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 7 MinIO IT classes are covered by @Disabled with a clear reason referencing CAMEL-24750, and all public camel-test-infra-minio service types are marked @Deprecated(since = "4.23"). Both suggestions from the previous review are addressed. No production code changes, no downstream impact. Solid.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

@apupier
apupier merged commit 62394ff into apache:main Sep 28, 2026
6 checks passed
@apupier
apupier deleted the deactivateMinioITTests branch September 28, 2026 08:13
@gnodet gnodet removed the port/camel-4.22.x Bug needs porting to camel-4.22.x label Sep 28, 2026
@gnodet

gnodet commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

🔄 Backport Bot

Port PRs created:

Conflicts (🤖 agent dispatched to resolve):

  • ⚠️ camel-4.18.x — Cherry-pick conflict in: test-infra/camel-test-infra-minio/src/main/java/org/apache/camel/test/infra/minio/services/MinioLocalContainerInfraService.java, test-infra/camel-test-infra-minio/src/main/java/org/apache/camel/test/infra/minio/services/MinioServiceFactory.java

ℹ️ If you push additional commits after /port, use /port again to update the port PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

components port/camel-4.18.x Bug needs porting to camel-4.18.x test-infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants