Skip to content

CAMEL-23250: Migrate remaining secret=true to security="secret"#22772

Merged
gnodet merged 3 commits into
mainfrom
CAMEL-23250-migrate-secret-annotations
Apr 25, 2026
Merged

CAMEL-23250: Migrate remaining secret=true to security="secret"#22772
gnodet merged 3 commits into
mainfrom
CAMEL-23250-migrate-secret-annotations

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented Apr 25, 2026

CAMEL-23250

Summary

Follow-up to PR #22269. Migrates all remaining secret = true annotations to the new security = "secret" attribute introduced in the security policy enforcement framework.

  • Replaces secret = true with security = "secret" on @UriParam and @Metadata annotations across 142 source files (~400 occurrences)
  • Covers components, core vault configurations, and SSL configuration
  • Regenerates all downstream artifacts (catalog JSON, endpoint DSL, component DSL)
  • The secret attribute was deprecated in 4.19.0 in favor of security = "secret"

Scope

  • 135 component files (AI, AWS, Azure, Google, IBM, Huawei, Kafka, JMS, FTP, etc.)
  • 7 core/tooling files (vault configs for AWS, Azure, GCP, HashiCorp, Spring Cloud Config; SSL config)
  • No behavioral changes — security = "secret" is semantically equivalent to secret = true

Remaining follow-up work

  • Camel Spring Boot — Auto-configuration for camel.security.* properties
  • Camel Quarkus — Integration for camel.security.* properties

Test plan

  • Full build passes (mvn install -Dquickly)
  • Zero secret = true remaining in non-test source files
  • Generated metadata regenerated and committed
  • CI build passes

@gnodet gnodet requested review from davsclaus and oscerd April 25, 2026 13:55
@gnodet gnodet force-pushed the CAMEL-23250-migrate-secret-annotations branch from 9f602fe to a0af2a2 Compare April 25, 2026 14:02
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

gnodet and others added 2 commits April 25, 2026 15:09
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gnodet gnodet force-pushed the CAMEL-23250-migrate-secret-annotations branch from a0af2a2 to 67df0fb Compare April 25, 2026 14:10
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • catalog/camel-catalog
  • components/camel-ai/camel-docling
  • components/camel-ai/camel-milvus
  • components/camel-ai/camel-neo4j
  • components/camel-ai/camel-openai
  • components/camel-ai/camel-pinecone
  • components/camel-ai/camel-qdrant
  • components/camel-ai/camel-weaviate
  • components/camel-amqp
  • components/camel-arangodb
  • components/camel-as2/camel-as2-component
  • components/camel-asterisk
  • components/camel-azure/camel-azure-cosmosdb
  • components/camel-azure/camel-azure-eventgrid
  • components/camel-azure/camel-azure-eventhubs
  • components/camel-azure/camel-azure-files
  • components/camel-azure/camel-azure-functions
  • components/camel-azure/camel-azure-key-vault
  • components/camel-azure/camel-azure-servicebus
  • components/camel-azure/camel-azure-storage-blob
  • components/camel-azure/camel-azure-storage-datalake
  • components/camel-azure/camel-azure-storage-queue
  • components/camel-bonita
  • components/camel-box/camel-box-component
  • components/camel-braintree
  • components/camel-camunda
  • components/camel-cassandraql
  • components/camel-clickup
  • components/camel-coap
  • components/camel-cometd
  • components/camel-consul
  • components/camel-couchbase
  • components/camel-couchdb
  • components/camel-crypto
  • components/camel-cxf/camel-cxf-soap
  • components/camel-dhis2/camel-dhis2-component
  • components/camel-digitalocean
  • components/camel-docker
  • components/camel-dropbox
  • components/camel-elasticsearch-rest-client
  • components/camel-elasticsearch
  • components/camel-fhir/camel-fhir-component
  • components/camel-ftp-common
  • components/camel-ftp
  • components/camel-geocoder
  • components/camel-git
  • components/camel-github
  • components/camel-github2
  • components/camel-google/camel-google-calendar
  • components/camel-google/camel-google-drive
  • components/camel-google/camel-google-mail
  • components/camel-google/camel-google-sheets
  • components/camel-graphql
  • components/camel-grpc
  • components/camel-hashicorp-vault
  • components/camel-http-common
  • components/camel-http
  • components/camel-ibm/camel-ibm-cos
  • components/camel-ibm/camel-ibm-secrets-manager
  • components/camel-ibm/camel-ibm-watson-discovery
  • components/camel-ibm/camel-ibm-watson-language
  • components/camel-ibm/camel-ibm-watson-speech-to-text
  • components/camel-ibm/camel-ibm-watson-text-to-speech
  • components/camel-ibm/camel-ibm-watsonx-ai
  • components/camel-ibm/camel-ibm-watsonx-data
  • components/camel-iggy
  • components/camel-infinispan/camel-infinispan
  • components/camel-irc
  • components/camel-ironmq
  • components/camel-jetty-common
  • components/camel-jetty
  • components/camel-jira
  • components/camel-jmx
  • components/camel-jsch
  • components/camel-jt400
  • components/camel-kafka
  • components/camel-keycloak
  • components/camel-kubernetes
  • components/camel-mail
  • components/camel-milo
  • components/camel-minio
  • components/camel-mongodb
  • components/camel-netty
  • components/camel-opensearch
  • components/camel-openstack
  • components/camel-pg-replication-slot
  • components/camel-pgevent
  • components/camel-pqc
  • components/camel-pubnub
  • components/camel-rocketmq
  • components/camel-salesforce/camel-salesforce-component
  • components/camel-sap-netweaver
  • components/camel-servicenow/camel-servicenow-component
  • components/camel-slack
  • components/camel-smb
  • components/camel-smpp
  • components/camel-snmp
  • components/camel-solr
  • components/camel-splunk-hec
  • components/camel-ssh
  • components/camel-stitch
  • components/camel-stomp
  • components/camel-stripe
  • components/camel-tahu
  • components/camel-telegram
  • components/camel-twilio
  • components/camel-twitter
  • components/camel-whatsapp
  • components/camel-workday
  • components/camel-xmpp
  • components/camel-zeebe
  • components/camel-zendesk
  • components/camel-zookeeper-master
  • core/camel-api
  • core/camel-core-model
  • core/camel-main

ℹ️ Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the test-dependents label to force testing all dependents.

⚠️ Some tests are disabled on GitHub Actions (@DisabledIfSystemProperty(named = "ci.env.name")) and require manual verification:

  • components/camel-ai/camel-docling: 6 test(s) disabled on GitHub Actions
  • components/camel-ai/camel-openai: 6 test(s) disabled on GitHub Actions
  • components/camel-arangodb: 9 test(s) disabled on GitHub Actions
  • components/camel-couchbase: 6 test(s) disabled on GitHub Actions
  • components/camel-grpc: 1 test(s) disabled on GitHub Actions
  • components/camel-http: 1 test(s) disabled on GitHub Actions
  • components/camel-iggy: 4 test(s) disabled on GitHub Actions
  • components/camel-infinispan/camel-infinispan: 2 test(s) disabled on GitHub Actions
  • components/camel-jetty: 3 test(s) disabled on GitHub Actions
  • components/camel-kafka: 3 test(s) disabled on GitHub Actions
  • components/camel-netty: 1 test(s) disabled on GitHub Actions
  • components/camel-rocketmq: 2 test(s) disabled on GitHub Actions
  • components/camel-stomp: 1 test(s) disabled on GitHub Actions
  • components/camel-tahu: 1 test(s) disabled on GitHub Actions
  • components/camel-xmpp: 6 test(s) disabled on GitHub Actions
Build reactor — dependencies compiled but only changed modules were tested (116 modules)
  • Camel :: AI :: Docling
  • Camel :: AI :: Milvus
  • Camel :: AI :: Neo4j
  • Camel :: AI :: OpenAI
  • Camel :: AI :: Pinecone
  • Camel :: AI :: Qdrant
  • Camel :: AI :: Weaviate
  • Camel :: AMQP
  • Camel :: API
  • Camel :: AS2 :: Component
  • Camel :: ArangoDB
  • Camel :: Asterisk
  • Camel :: Azure :: CosmosDB
  • Camel :: Azure :: Event Grid
  • Camel :: Azure :: Event Hubs
  • Camel :: Azure :: Files
  • Camel :: Azure :: Functions
  • Camel :: Azure :: Key Vault
  • Camel :: Azure :: ServiceBus
  • Camel :: Azure :: Storage Blob
  • Camel :: Azure :: Storage Datalake
  • Camel :: Azure :: Storage Queue
  • Camel :: Bonita
  • Camel :: Box :: Component
  • Camel :: Braintree
  • Camel :: CXF :: SOAP
  • Camel :: Camunda
  • Camel :: Cassandra CQL
  • Camel :: Catalog :: Camel Catalog
  • Camel :: ClickUp
  • Camel :: CoAP
  • Camel :: Cometd
  • Camel :: Consul
  • Camel :: Core Model
  • Camel :: CouchDB
  • Camel :: Couchbase
  • Camel :: Crypto
  • Camel :: DHIS2
  • Camel :: DigitalOcean
  • Camel :: Docker
  • Camel :: Dropbox
  • Camel :: ElasticSearch Java API Client
  • Camel :: ElasticSearch Rest Client
  • Camel :: FHIR
  • Camel :: FTP
  • Camel :: FTP Common
  • Camel :: Geocoder
  • Camel :: Git
  • Camel :: GitHub
  • Camel :: GitHub2
  • Camel :: Google :: Calendar
  • Camel :: Google :: Drive
  • Camel :: Google :: Mail
  • Camel :: Google :: Sheets
  • Camel :: GraphQL
  • Camel :: HTTP
  • Camel :: HTTP :: Common
  • Camel :: Hashicorp :: Key Vault
  • Camel :: IBM :: Cloud Object Storage
  • Camel :: IBM :: Secrets Manager
  • Camel :: IBM :: Watson Discovery
  • Camel :: IBM :: Watson Language
  • Camel :: IBM :: Watson Speech to Text
  • Camel :: IBM :: Watson Text to Speech
  • Camel :: IBM :: watsonx.ai
  • Camel :: IBM :: watsonx.data
  • Camel :: IRC
  • Camel :: Iggy
  • Camel :: Infinispan :: Remote
  • Camel :: IronMQ
  • Camel :: JIRA
  • Camel :: JMX
  • Camel :: Java Toolbox for IBM i
  • Camel :: Jetty
  • Camel :: Jetty :: Common
  • Camel :: Jsch
  • Camel :: Kafka
  • Camel :: Keycloak
  • Camel :: Kubernetes
  • Camel :: Mail
  • Camel :: Main
  • Camel :: Milo
  • Camel :: MinIO
  • Camel :: MongoDB
  • Camel :: Netty
  • Camel :: OpenSearch Java API Client
  • Camel :: OpenStack
  • Camel :: PQC
  • Camel :: PgEvent
  • Camel :: PgReplicationSlot
  • Camel :: PubNub
  • Camel :: RocketMQ
  • Camel :: SAP NetWeaver
  • Camel :: SMB
  • Camel :: SMPP
  • Camel :: SNMP
  • Camel :: SSH
  • Camel :: Salesforce
  • Camel :: ServiceNow :: Component
  • Camel :: Slack
  • Camel :: Solr
  • Camel :: Splunk HEC
  • Camel :: Stitch
  • Camel :: Stomp (Deprecated)
  • Camel :: Stripe
  • Camel :: Tahu
  • Camel :: Telegram
  • Camel :: Twilio
  • Camel :: Twitter
  • Camel :: Whatsapp
  • Camel :: Workday
  • Camel :: XMPP
  • Camel :: Zeebe (deprecated)
  • Camel :: Zendesk
  • Camel :: Zookeeper Master
  • Camel :: gRPC

⚙️ View full build and test results

@gnodet gnodet merged commit c9c34a1 into main Apr 25, 2026
6 checks passed
@gnodet gnodet deleted the CAMEL-23250-migrate-secret-annotations branch April 25, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants