Repository navigation
Conversation
Comment on lines
+153
to
+156
| if (_length != kScanningLine) { | ||
| _type = REDIS_REPLY_NIL; | ||
| _length = kScanningLine; | ||
| _data.line = {}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What problem does this PR solve?
Problem Summary:
Inline Redis commands and simple-string replies restart their CRLF search
from the beginning whenever more input arrives. Small fragments repeatedly
scan the same bytes and backing blocks.
What is changed and the side effects?
Changed:
crossing backing blocks, and scan limits.
Side effects:
later reads. Each command parser stores 16 bytes of scan state.
bytes must remain unchanged while the parser waits for more data.
Check List: