Skip to content

Retain Redis argument storage until a transaction completes - #3665

Open
wasphin wants to merge 1 commit into
apache:masterfrom
wasphin:fix-redis-transaction-argument-storage
Open

wasphin wants to merge 1 commit into
apache:masterfrom
wasphin:fix-redis-transaction-argument-storage

Conversation

@wasphin

@wasphin wasphin commented Oct 25, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Problem Summary:

A Redis transaction can retain argument views across separate reads. The
connection currently clears its argument arena at the end of a read even
when a transaction handler is still active, so later reads can overwrite
those arguments before the transaction executes.

What is changed and the side effects?

Changed:

  • Retain the argument arena while a transaction handler is active.
  • Document the argument-string lifetime during a transaction.
  • Add a real connection regression with separate requests and repeated
    transactions that retain argument views.

Side effects:

  • Performance effects: Argument storage is retained until the transaction
    completes; its memory use depends on the accumulated transaction data.
  • Breaking backward compatibility: No API signature changes.

Check List:

@chenBright
chenBright requested a balanced review from Copilot October 26, 2026 03:06

This comment was marked as low quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants