Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The regression tests need deterministic escaping coverage and matching resolver buffer sizes to avoid environment-dependent failures.
2 open issues
What changed in this PR
This PR escapes resolved hostnames in bRPC’s HTML connections page while preserving plain-text output.
Changes:
- Pass the output format to hostname rendering for both normal and broken connections.
- Add hostname-enabled checks for HTML and plain-text responses.
- Use an ephemeral port in connection tests.
| File | Description |
|---|---|
| test/brpc_builtin_service_unittest.cpp | Adds hostname-display coverage and uses an ephemeral server port. |
| src/brpc/builtin/connections_service.cpp | Escapes resolved hostnames only when rendering HTML. |
Review effort: Balanced
| EXPECT_EQ(expect_type, cntl.http_response().content_type()); | ||
| CheckContent(cntl, buf); | ||
| if (brpc::FLAGS_show_hostname_instead_of_ip) { | ||
| char hostname[256]; |
Comment on lines
+709
to
+713
| TEST_F(BuiltinServiceTest, connections_with_hostnames) { | ||
| GFLAGS_NAMESPACE::FlagSaver flag_saver; | ||
| brpc::FLAGS_show_hostname_instead_of_ip = true; | ||
| TestConnections(false); | ||
| TestConnections(true); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
The connections page inserts resolved hostnames directly into HTML output.
What is changed and the side effects?
Changed:
Side effects:
Check List: