Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized checks preserve pool state on failure, and the regression covers failure and recovery paths; tests were not executed during this review.
No open issues 🎉
What changed in this PR
This PR makes bRPC’s bundled RapidJSON memory pool handle backing-allocation failures without dereferencing null pointers or altering existing pool contents.
Changes:
- Return null when chunk allocation or buffer growth fails.
- Add regression coverage for allocation failures, state preservation, and successful recovery.
- Register the regression test in CMake and Bazel.
| File | Description |
|---|---|
test/rapidjson_allocator_unittest.cc |
Tests failure handling, preserved contents, and recovery. |
test/CMakeLists.txt |
Adds the regression to the CMake test sources. |
test/BUILD.bazel |
Adds the regression to the Bazel test sources. |
src/butil/third_party/rapidjson/allocators.h |
Checks allocation results before modifying chunks or copying data. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
The JSON memory pool dereferences a failed chunk allocation and assumes a successful allocation when growing a buffer.
What is changed and the side effects?
Changed:
Side effects:
Check List: