Skip to content

Respect splitter field bounds in numeric conversions - #3660

Open
wasphin wants to merge 1 commit into
apache:masterfrom
wasphin:fix-splitter-numeric-field-bounds
Open

wasphin wants to merge 1 commit into
apache:masterfrom
wasphin:fix-splitter-numeric-field-bounds

Conversation

@wasphin

@wasphin wasphin commented Oct 25, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Problem Summary:

Numeric conversion of a bounded splitter field passes its start to C conversion routines without terminating it at the field end. A numeric suffix outside the field can affect conversion.

What is changed and the side effects?

Changed:

  • Convert a terminated copy of the current field in both splitter classes.
  • Document that conversions use only the current field.
  • Cover all six numeric conversion routines with a numeric suffix and a buffer without a trailing NUL.

Side effects:

  • Performance effects: Copies the current field for numeric conversion.
  • Breaking backward compatibility: Numeric separators now delimit numeric fields in the same way as other separators. No API signature changes.

Check List:

@chenBright
chenBright requested a balanced review from Copilot October 26, 2026 03:02

This comment was marked as low quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants