Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new regression needs a MesaLink guard because that backend does not emit the certificate fields it asserts.
1 open issue
What changed in this PR
This PR fixes temporary resource leaks in bRPC’s SSL diagnostic output.
Changes:
- Adds scoped ownership for peer certificates and diagnostic BIO buffers.
- Adds an in-memory TLS regression checking certificate release after repeated diagnostic output.
| File | Description |
|---|---|
test/brpc_ssl_unittest.cpp |
Adds regression coverage for peer-certificate cleanup. |
src/brpc/details/ssl_helper.cpp |
Automatically releases certificate references and BIO buffers. |
Review effort: Balanced
Comment on lines
+150
to
+151
| EXPECT_NE(std::string::npos, os.str().find("peer_certificate={")); | ||
| EXPECT_NE(std::string::npos, os.str().find("subject=")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Printing an SSL session obtains an owning peer-certificate reference, and printing a certificate allocates a BIO. Repeated diagnostic output retains both resources.
What is changed and the side effects?
Changed:
Side effects:
Check List: