Repository navigation
Fix comment and test-string typos - #3652
Merged
Merged
Conversation
overriden -> overridden (2), occured -> occurred, acess -> access, Sucess -> Success (unasserted test payload). No behavior change. Signed-off-by: NUAAwqy <146524024+NUAAwqy@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to spelling corrections, with no production logic changes or affected test assertions.
No open issues 🎉
What changed in this PR
This PR corrects spelling in bRPC comments and a test response string without changing production behavior.
Changes:
- Corrects “overridden,” “occurred,” and “access” in four source comments.
- Changes an unasserted test response payload from “Sucess” to “Success.”
| File | Description |
|---|---|
test/brpc_http_rpc_protocol_unittest.cpp |
Corrects the test response string to “Success.” |
src/butil/reloadable_flags.h |
Corrects “access” in flag-access documentation. |
src/brpc/policy/mongo_protocol.cpp |
Corrects “occurred” in a connection-context comment. |
src/brpc/details/tcmalloc_extension.cpp |
Corrects “overridden” in a weak-function comment. |
src/brpc/channel.cpp |
Corrects “overridden” in an option-validation comment. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a handful of comment typos found by code search (no behavior change):