Skip to content

Prefer binary wheels when installing Python container dependencies#39402

Merged
Abacn merged 3 commits into
apache:masterfrom
aIbrahiim:py314-docker-build-improvements
Jul 22, 2026
Merged

Prefer binary wheels when installing Python container dependencies#39402
Abacn merged 3 commits into
apache:masterfrom
aIbrahiim:py314-docker-build-improvements

Conversation

@aIbrahiim

Copy link
Copy Markdown
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces optimizations to the Python container build process to significantly reduce build times. By leveraging Docker registry caching and prioritizing pre-built binary wheels during dependency installation, the changes streamline the CI/CD pipeline for container images.

Highlights

  • Docker Build Optimization: Implemented registry-based caching for Docker builds using BuildKit, allowing layers to be shared and reused across builds.
  • Gradle Plugin Updates: Updated BeamDockerPlugin to support cache-from and cache-to configurations and added a helper to generate registry cache references.
  • Pip Installation Improvements: Added the --prefer-binary flag to pip installations in Dockerfiles and requirement generation scripts to speed up builds by avoiding unnecessary source compilations.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/beam_PostCommit_Python_Arm.yml
    • .github/workflows/beam_Publish_Beam_SDK_Snapshots.yml
    • .github/workflows/beam_Python_ValidatesContainer_Dataflow_ARM.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Docker BuildKit layer caching in the Beam Python SDK container builds by adding cacheFrom and cacheTo options, and configures pip install to prefer binary wheels to speed up builds. The review feedback highlights two critical issues: first, a runtime MissingMethodException in BeamDockerPlugin.groovy due to an incorrect usage of List.addAll with multiple string arguments instead of a collection; second, a fragile image name parsing logic in BeamModulePlugin.groovy that fails when registry names contain port numbers (e.g., localhost:5000), which can be resolved by checking the position of the last colon relative to the last slash.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread buildSrc/src/main/groovy/org/apache/beam/gradle/BeamDockerPlugin.groovy Outdated
Comment thread buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy Outdated
@aIbrahiim
aIbrahiim marked this pull request as draft July 21, 2026 12:53

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to implemented a docker cache in Dataflow templates container build. It produced lots of temporary entries in artifact registry taking lots of time to clean up, while the speed up time was minimum.

If we implement a cache here we may also need to handle the clean up in https://github.com/apache/beam/blob/master/.test-infra/tools/stale_dataflow_prebuilt_image_cleaner.sh

prefer-binary sounds a good improvement if it works well

@github-actions github-actions Bot removed the build label Jul 22, 2026
@aIbrahiim aIbrahiim changed the title Speed up Python container builds with prefer-binary and registry cache Prefer binary wheels when installing Python container dependencies Jul 22, 2026
@aIbrahiim
aIbrahiim requested a review from Abacn July 22, 2026 09:29
@aIbrahiim
aIbrahiim marked this pull request as ready for review July 22, 2026 09:29
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.78%. Comparing base (de21b1c) to head (a0daf37).
⚠️ Report is 68 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #39402      +/-   ##
============================================
+ Coverage     54.76%   54.78%   +0.02%     
  Complexity     1716     1716              
============================================
  Files          1066     1069       +3     
  Lines        169075   169126      +51     
  Branches       1255     1255              
============================================
+ Hits          92589    92657      +68     
+ Misses        74269    74252      -17     
  Partials       2217     2217              
Flag Coverage Δ
python 79.75% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Abacn
Abacn merged commit d2d7ef8 into apache:master Jul 22, 2026
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants