Prefer binary wheels when installing Python container dependencies#39402
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces optimizations to the Python container build process to significantly reduce build times. By leveraging Docker registry caching and prioritizing pre-built binary wheels during dependency installation, the changes streamline the CI/CD pipeline for container images. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for Docker BuildKit layer caching in the Beam Python SDK container builds by adding cacheFrom and cacheTo options, and configures pip install to prefer binary wheels to speed up builds. The review feedback highlights two critical issues: first, a runtime MissingMethodException in BeamDockerPlugin.groovy due to an incorrect usage of List.addAll with multiple string arguments instead of a collection; second, a fragile image name parsing logic in BeamModulePlugin.groovy that fails when registry names contain port numbers (e.g., localhost:5000), which can be resolved by checking the position of the last colon relative to the last slash.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Abacn
left a comment
There was a problem hiding this comment.
We used to implemented a docker cache in Dataflow templates container build. It produced lots of temporary entries in artifact registry taking lots of time to clean up, while the speed up time was minimum.
If we implement a cache here we may also need to handle the clean up in https://github.com/apache/beam/blob/master/.test-infra/tools/stale_dataflow_prebuilt_image_cleaner.sh
prefer-binary sounds a good improvement if it works well
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39402 +/- ##
============================================
+ Coverage 54.76% 54.78% +0.02%
Complexity 1716 1716
============================================
Files 1066 1069 +3
Lines 169075 169126 +51
Branches 1255 1255
============================================
+ Hits 92589 92657 +68
+ Misses 74269 74252 -17
Partials 2217 2217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.