Skip to content

Make FirestoreV1 Transform bases public for worker access#39324

Draft
aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:fix/firestore-readtransform-visibility
Draft

Make FirestoreV1 Transform bases public for worker access#39324
aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:fix/firestore-readtransform-visibility

Conversation

@aIbrahiim

Copy link
Copy Markdown
Contributor

After Java 21 bump on #39205, PostCommit Java Dataflow V1 started failing on FirestoreV1IT (batchGet, listDocuments, runQuery, partitionQuery).

The crash is IllegalAccessError on FirestoreV1$ReadTransform while the Dataflow worker loads IT DoFns and java 21 compiles BaseFirestoreIT with references to private nested types (Transform / ReadTransform) from withProjectId / withDatabaseId on the classic worker that trips getSimpleName() inside DoFnSignatures.

so the fix is making Transform, ReadTransform, and their Builders public and also make two worker DoFns package-private to match the other Firestore DoFns.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn

Abacn commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

This exposes a Java17+ compatibility issue that user PTransform and DoFn defined as private static class may also fail. Testing an alternative fix in https://github.com/apache/beam/actions/runs/29358766897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants