Make FirestoreV1 Transform bases public for worker access#39324
Draft
aIbrahiim wants to merge 1 commit into
Draft
Make FirestoreV1 Transform bases public for worker access#39324aIbrahiim wants to merge 1 commit into
aIbrahiim wants to merge 1 commit into
Conversation
Contributor
|
This exposes a Java17+ compatibility issue that user PTransform and DoFn defined as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After Java 21 bump on #39205, PostCommit Java Dataflow V1 started failing on FirestoreV1IT (batchGet, listDocuments, runQuery, partitionQuery).
The crash is IllegalAccessError on FirestoreV1$ReadTransform while the Dataflow worker loads IT DoFns and java 21 compiles BaseFirestoreIT with references to private nested types (Transform / ReadTransform) from withProjectId / withDatabaseId on the classic worker that trips getSimpleName() inside DoFnSignatures.
so the fix is making Transform, ReadTransform, and their Builders public and also make two worker DoFns package-private to match the other Firestore DoFns.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.