Skip to content

KeyCommitTooLarge logging improvements#39316

Open
rwiggles wants to merge 5 commits into
apache:masterfrom
rwiggles:master
Open

KeyCommitTooLarge logging improvements#39316
rwiggles wants to merge 5 commits into
apache:masterfrom
rwiggles:master

Conversation

@rwiggles

@rwiggles rwiggles commented Jul 14, 2026

Copy link
Copy Markdown

Support logging the key during a KeyCommitTooLarge if EnableHotKeyLogging is turned on. Also switch to logging the dfe name instead of the computation name and fix an overflow in logging the sharding key.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

rwiggles and others added 2 commits July 14, 2026 00:22
…ging is turned on. Also switch to logging the dfe name instead of the computation name and fix an overflow in logging the sharding key
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the logging capabilities for KeyCommitTooLargeException in the Dataflow worker. By allowing the inclusion of the specific key in error messages, it improves debuggability for large commit issues. The change introduces a configurable flag to toggle this behavior, ensuring it can be enabled selectively via worker options or experiment flags.

Highlights

  • Hot Key Logging: Introduced an optional hot key logging feature that includes the key in the KeyCommitTooLargeException error message when enabled.
  • Configuration: Added a new boolean flag 'hotKeyLoggingEnabled' to the StreamingWorkScheduler, configurable via worker options or an experiment flag.
  • Testing: Expanded StreamingDataflowWorkerTest to verify that the key is correctly included or excluded from error messages based on the configuration.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for hot key logging in KeyCommitTooLargeException by passing a hotKeyLoggingEnabled flag and updates the streaming work scheduler and tests accordingly. However, the changes introduce several compilation issues due to importing standard instead of vendored dependencies (Guava, Protobuf, and gRPC) across multiple files, as well as importing DataflowRunner into the worker module, which causes a circular dependency. The feedback advises replacing these with their vendored counterparts and checking the experiments list directly from the options.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

rwiggles and others added 3 commits July 14, 2026 11:01
…ache/beam/runners/dataflow/worker/streaming/KeyCommitTooLargeException.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ache/beam/runners/dataflow/worker/windmill/work/processing/StreamingWorkScheduler.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant