MINOR: [c] avoid signed left-shift overflow in binary varint decoder#3896
Open
arib06 wants to merge 1 commit into
Open
MINOR: [c] avoid signed left-shift overflow in binary varint decoder#3896arib06 wants to merge 1 commit into
arib06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cast each 7-bit group in read_long (and the big-endian float/double byte assembly) to unsigned before shifting, so a 10-byte long whose final byte sets bit 63 no longer left-shifts a signed value into the sign bit (UBSAN: left shift of 1 by 63 places in int64_t), matching the unsigned accumulation the C++ decoder already uses.